Fix omitting default values (#8)

Copy the whole chart expect templates (not only values.yaml), because
other plugins can take values from other files

Author: Nitive

e2e-tests/charts/one-service/deno-templates/index.ts

@@ -6,6 +6,7 @@ interface ChartContext {
   values: {
     serviceName?: string
     selector: Record<string, string>
+    annotations: Record<string, string>
   }
 }
 
@@ -20,6 +21,7 @@ export default function oneService(c: ChartContext) {
       apiVersion: "v1",
       metadata: {
         name: c.values.serviceName || c.release.name,
+        annotations: c.values.annotations,
       },
       spec: {
         selector: c.values.selector,

e2e-tests/charts/one-service/values.yaml

@@ -0,0 +1,2 @@
+annotations:
+  default-annotation: default-value

e2e-tests/e2e.test.ts

@@ -45,6 +45,14 @@ async function runHelmDeno(args: string[]) {
   return await run([helmDenoBin, ...args])
 }
 
+async function assertYamlParsable(yamlFileContent: string) {
+  try {
+    await yaml.parseAll(yamlFileContent)
+  } catch (err) {
+    throw new Error(`Cloud parse yaml context ${err} ${yamlFileContent}`)
+  }
+}
+
 Deno.test({
   name: "should successfuly run `helm deno template` with deno chart",
   async fn() {
@@ -65,6 +73,9 @@ Deno.test({
         kind: "Service",
         metadata: {
           name: "my-release-name",
+          annotations: {
+            "default-annotation": "default-value",
+          },
         },
         spec: {
           ports: [
@@ -117,7 +128,6 @@ Deno.test(
       stdout.replaceAll(helmPluginDir, ""),
       `\
 ==> Linting /e2e-tests/charts/one-service
-[INFO] values.yaml: file does not exist
 [WARNING] templates/: directory not found
 
 1 chart(s) linted, 0 chart(s) failed
@@ -220,6 +230,9 @@ Deno.test({
         kind: "Service",
         metadata: {
           name: "my-release-name",
+          annotations: {
+            "default-annotation": "default-value",
+          },
         },
         spec: {
           ports: [
@@ -584,6 +597,9 @@ Deno.test({
         kind: "Service",
         metadata: {
           name: "my-release-name",
+          annotations: {
+            "default-annotation": "default-value",
+          },
         },
         spec: {
           ports: [
@@ -650,7 +666,7 @@ Deno.test({
     "should successfuly run `helm deno template` with remote deno chart (with --repo option)",
   ignore: !runAllTests,
   async fn() {
-    const { status } = await runHelmDeno([
+    const { status, stdout, stderr } = await runHelmDeno([
       "template",
       "ingress",
       "nginx-ingress",
@@ -660,7 +676,8 @@ Deno.test({
       "1.41.3",
     ])
 
-    assertEquals(status.success, true)
+    await assertYamlParsable(stdout)
+    assertEquals(status.success, true, stderr)
   },
 })
 
@@ -702,7 +719,8 @@ Deno.test({
         "1.41.3",
       ])
 
-      assertEquals(templateCmd.status.success, true)
+      await assertYamlParsable(templateCmd.stdout)
+      assertEquals(templateCmd.status.success, true, templateCmd.stderr)
     } finally {
       await tmpRepo.cleanup()
     }

src/helm/get-chart-context.ts

@@ -35,11 +35,17 @@ function normalizeRelease(r: HelmRelease): Release {
 export async function getChartContext(
   release: string,
   tmpDir: string,
+  chartDir: string,
   args: readonly string[]
 ): Promise<ChartContext> {
   const getValuesChartDir = path.join(tmpDir, "get-values-chart")
   try {
-    await fs.ensureDir(path.join(getValuesChartDir, "templates"))
+    await fs.copy(chartDir, getValuesChartDir)
+    const getValuesTemplatesDir = path.join(getValuesChartDir, "templates")
+    await ignoreNotFoundError(
+      Deno.remove(getValuesTemplatesDir, { recursive: true })
+    )
+    await fs.ensureDir(getValuesTemplatesDir)
 
     await Deno.writeFile(
       path.join(getValuesChartDir, "templates/values-and-release.yaml"),

src/index.ts

@@ -131,7 +131,12 @@ async function main() {
       debug(`Successfuly fetched chart ${chartLocation} to temporary directory`)
     }
 
-    const chartContext = await getChartContext(releaseName, tmpDir, args)
+    const chartContext = await getChartContext(
+      releaseName,
+      tmpDir,
+      tmpChartPath,
+      args
+    )
     debug(`Chart context:\n${JSON.stringify(chartContext, null, 2)}`)
 
     await renderDenoChart(chartContext, tmpChartPath, options)