Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Two identical references for Republic of Ireland and Ireland #332

Closed
EI8EJB opened this issue Mar 9, 2020 · 4 comments
Closed

Two identical references for Republic of Ireland and Ireland #332

EI8EJB opened this issue Mar 9, 2020 · 4 comments

Comments

@EI8EJB
Copy link

EI8EJB commented Mar 9, 2020

There are two references for the Republic of Ireland. Should be amended to show only as "Republic of Ireland" and the additional "Ireland" reference which should be removed to avoid confusion. The data figure for Northern Ireland lies within the data set for the UK.

@Bost
Copy link

Bost commented Mar 9, 2020

It's obviously too late now[1] but to avoid confusion the norm ISO_3166-1 should had been used. More precisely the 2 or 3 letter country codes. I personally map all the non-standard names to the names provided by the ISO norm:

and then use the 2 letter country code in my project(s).

[1] #238 Do not change it !!!

@plt005
Copy link

plt005 commented Mar 9, 2020

To avoid changing the current data structure it would be very helpful to provide a separate data set mapping the country/region names to the ISO_3166-1 codes.

@Bost
Copy link

Bost commented Mar 9, 2020

@plt005 this merge effort may interest you Bost/corona_cases#1

@EI8EJB
Copy link
Author

EI8EJB commented Mar 9, 2020

Well done and many thanks for the VERY fast response. Regards!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants