Skip to content

Fix HttpsCallable return type. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix HttpsCallable return type. #210

merged 1 commit into from
Feb 23, 2022

Conversation

sanny-io
Copy link
Contributor

Considering the following line:

const [submit] = useHttpsCallable<ContactFields, boolean>(functions, 'sendContact')

The return type for submit is Promise<unknown>. With this change, the return type is Promise<HttpsCallableResult<boolean> | undefined>

@chrisbianca
Copy link
Contributor

@sanny-io This is a good catch, thanks for the PR - will merge and release shortly

@chrisbianca chrisbianca merged commit d1d6f0b into CSFrequency:master Feb 23, 2022
@Mdizrail92 Mdizrail92 mentioned this pull request Jun 15, 2024
Open
@Skrishnan586 Skrishnan586 mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanny-io @chrisbianca