Skip to content

Commit 866966d

Browse files
authored
Merge pull request #249 from wong2/fix-hook-perf
Fix useLoadingValue perf issue
2 parents 05bb93b + 22f7a51 commit 866966d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

util/useLoadingValue.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useMemo, useReducer } from 'react';
1+
import { useCallback, useMemo, useReducer } from 'react';
22

33
export type LoadingValue<T, E> = {
44
error?: E;
@@ -60,18 +60,18 @@ export default <T, E>(getDefaultValue?: () => T): LoadingValue<T, E> => {
6060
defaultState(defaultValue)
6161
);
6262

63-
const reset = () => {
63+
const reset = useCallback(() => {
6464
const defaultValue = getDefaultValue ? getDefaultValue() : undefined;
6565
dispatch({ type: 'reset', defaultValue });
66-
};
66+
}, [getDefaultValue]);
6767

68-
const setError = (error: E) => {
68+
const setError = useCallback((error: E) => {
6969
dispatch({ type: 'error', error });
70-
};
70+
}, []);
7171

72-
const setValue = (value?: T) => {
72+
const setValue = useCallback((value?: T) => {
7373
dispatch({ type: 'value', value });
74-
};
74+
}, []);
7575

7676
return useMemo(
7777
() => ({

0 commit comments

Comments
 (0)