Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils.music.get_time_maps_from_alignment removed from API without updating partitura.readthedocs.io #348

Open
eoinroe opened this issue Feb 14, 2024 · 3 comments · Fixed by #368
Labels
documentation Improvements or additions to documentation

Comments

@eoinroe
Copy link

eoinroe commented Feb 14, 2024

The example code from here has not been updated so when running it with the latest version of Partitura it produces the following error:

AttributeError: module 'partitura.utils.music' has no attribute 'get_time_maps_from_alignment'

It appears that get_time_maps_from_alginment has been completely removed from the API instead of being deprecated so it is unclear which method to use in its place.

@CarlosCancino-Chacon
Copy link
Member

Good catch! The method was moved to the performance_codec module (in musicanalysis) and can be accessed as follows:

from partitura.musicanalysis.performance_codec import get_time_maps_from_alignment

We'll update the tutorial and have a deprecation notification in utils.music to fix this issue.

@eoinroe
Copy link
Author

eoinroe commented Feb 14, 2024

Thanks for your swift reply! I am now able to run the code from the tutorial and recreate the plot using match files from the Vienna 4x22 Piano Corpus.

Cheers!

Copy link

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?

@github-actions github-actions bot added the stale label Aug 13, 2024
@sildater sildater linked a pull request Aug 13, 2024 that will close this issue
@sildater sildater reopened this Aug 27, 2024
@sildater sildater added documentation Improvements or additions to documentation and removed stale labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants