-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigation on single_step_call #140
Comments
Are you saying that |
After digging into the rabbit hole, it appears that we were misunderstanding the description of call get_param(param_file, mdl, "SINGLE_STEPPING_CALL", OS%single_step_call, &
"If true, advance the state of MOM with a single step "//&
"including both dynamics and thermodynamics. If false, "//&
"the two phases are advanced with separate calls.", default=.true.)
But both dynamics and thermodynamics advance together within a single subroutine call. Hence, Conversely, when |
I am now investigating why diagnostics are not exactly the same when turning it on and off. |
This is still confusing to me. If dynamics and thermo are advanced in a single call with |
Hi @aekiss After that, call step_MOM_dynamics(forces, CS%p_surf_begin, CS%p_surf_end, dt, &
dt_therm_here, bbl_time_int, CS, &
Time_local, Waves=Waves) |
Ah, ok thanks for the clarification. So
In both cases it looks (on a superficial skim) like within each coupling timestep the model loops over |
Yes, I think you are right. From my understading, when |
Description
As was proposed in ACCESS-NRI/access-om3-configs#48 (comment), there seems to be a discrepancy regarding the behavior of the
single_step_call
as described in the documentation and its actual implementation.According to the documentation snippet provided here,
single_step_call
parameter is in defaultTrue
, hence MOM advances its state with a single timestep, whereDT_THERMO
is neglected.Issue
However, this is not the case. That is, when
SINGLE_STEPPING_CALL
=True&
THERMO_SPANS_COUPLING
=True, MOM does not advance with a single timestep!Finding
dt_therm
is still in effect even whensingle_step_call
is set to True. This observation is further confirmed by a sanity check via print outputs.single_step_call
, the time consumption remains the same between two runs withthermo_does_span_coupling=True, dt=1350, and dt_thermo=2700
. Both are around 25% faster than a comparison run withthermo_does_span_coupling=False
I am currently investigating this issue as there seems to be some aspect that I am not yet aware of. This issue is considered critical as it could potentially affect the integrity of model solutions if left unresolved.
The text was updated successfully, but these errors were encountered: