Improve cli output pipeline and error handling

Author: CMTegner

bin/cli.js

@@ -1,6 +1,8 @@
 #!/usr/bin/env node
 var fs = require('fs');
+var path = require('path');
 var parse = require('../');
+var stringify = require('JSONStream').stringify;
 var args = require('nomnom')
     .option('output', {
         abbr: 'o',
@@ -40,28 +42,32 @@ if (!args.file) {
         });
 }
 
+var output;
+if (args.output) {
+    output = fs.createWriteStream(args.output)
+        .on('error', function(err) {
+            if (err.code === 'ENOENT') {
+                var dir = path.dirname(args.output);
+                console.error('No such directory: %s', dir);
+                process.exit(1);
+                return;
+            }
+            throw err;
+        });
+} else {
+    output = process.stdout
+        .on('error', function (err) {
+            if (process.stdout.isTTY) {
+                // Only throw output errors if we're in
+                // a TTY to prevent noise when piping
+                // the output to other commands
+                throw err;
+            }
+        });
+}
+
 var parser = parse();
 input
     .pipe(parser)
-    .on('data', function(data) {
-        var str = JSON.stringify(data);
-        if (args.output) {
-            fs.createWriteStream(args.output)
-                .on('error', function(err) {
-                    throw err;
-                })
-                .end(str, 'utf8');
-        } else {
-            process.stdout.write(str);
-        }
-    })
-    .on('end', function () {
-        if (!process.stdout.isTTY) {
-            // Prevent noise if the command you're
-            // piping the output to fails
-            process.exit(0);
-        }
-    })
-    .on('error', function (err) {
-        throw err;
-    });
+    .pipe(stringify(false))
+    .pipe(output);

package.json

@@ -27,6 +27,7 @@
   },
   "homepage": "https://github.com/CMTegner/jsonml-parse",
   "dependencies": {
+    "JSONStream": "^0.8.4",
     "htmlparser2": "^3.7.3",
     "lodash.isempty": "^2.4.1",
     "nomnom": "^1.8.0"

test/cli.sh

@@ -9,4 +9,7 @@ rm ${base}/cli/tmp.json
 set +e
 error=$(node ${base}/../bin/cli.js nope 2>&1)
 test $? -eq 1
-[ "$error" = "No such file: nope" ] || (echo "'No such file' logic is broken!"; exit 1)
+[ "$error" = "No such file: nope" ] || (echo "'No such file' logic is broken!"; exit 1)
+error=$(node ${base}/../bin/cli.js ${base}/cli/markup.html -o /nope/nope/nope 2>&1)
+test $? -eq 1
+[ "$error" = "No such directory: /nope/nope" ] || (echo "'No such output directory' logic is broken!"; exit 1)