Remove custom function allowance #225
Labels
enhancement
New feature or request
Next release
The issue has been merged into dev and will be part of the next release
Security
In ERC20BaseModule, we have a function
approve(address spender,uint256 amount,uint256 currentAllowance)
to be used to avoid the vulnerability describes here: google docWith OpenZeppelin v4.x, this functions was not necessary since we could use the functions
increaseAllowance
anddecreaseAllowance
Nevertheless, these two functions will be remove in the next OpenZeppelin release.
The reason behind this change should be to make us think if our custom approve function is really necessary, see OpenZeppelin/openzeppelin-contracts#4583
For example, Metamak put a warning with the standard approve function
But it is not the case for the custom approval function, which thus can be use to scam token holders
The text was updated successfully, but these errors were encountered: