Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in 'get_leakage_spectra' and 'get_leakage_beams" functions #10

Open
CesileyKing opened this issue Oct 10, 2023 · 1 comment
Open

Comments

@CesileyKing
Copy link
Contributor

norm_fac in both of these functions should be the entire spectrum that is being normalized by, not the maximum of that spectrum. That is, in MMTModules.py, lines 243 and 409 should read norm_fac = binned_spectra_dict['TT'][1:] ; lines 245 and 411 should read norm_fac = binned_spectra_dict['EE'][1:] ; and lines 247 and 413 should read norm_fac = binned_spectra_dict['BB'][1:] .

@laurensaunders
Copy link
Contributor

PR on 7/23/24 makes get_leakage_spectra2, which uses this normalization convention instead. Left the original get_leakage_spectra function as is because it is correct for beam systematics work. Did not touch get_leakage_beams--is that also a function we should copy over and switch the normalization for? Do you use get_leakage_beams (I haven't, at least thus far)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants