Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add libcmaes to conan #233

Open
phbasler opened this issue Mar 31, 2022 · 9 comments
Open

[feature request] Add libcmaes to conan #233

phbasler opened this issue Mar 31, 2022 · 9 comments

Comments

@phbasler
Copy link
Contributor

Hi @beniz ,

Did you consider publishing libcmaes as a conan package ( https://docs.conan.io/en/latest/uploading_packages/artifactory/conan_center_guide.html )?

It would be a nice way to include libcmaes in other repositories without having to build it ourselves.

@beniz
Copy link
Collaborator

beniz commented Apr 2, 2022

Hi @phbasler no, I don't have the bandwidth for this, though I can keep maintaining the basics as long as it's needed.
But please contribute it if you can, this seems useful!

@phbasler
Copy link
Contributor Author

phbasler commented Apr 5, 2022

Hi @beniz

I can help here. To be able to request PR to add new packages, they require to ask for access in a special issue ( https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md#request-access ).

Do you want to do that so you can add modifications/changes in the future? I can do the fork and local modifications

@beniz
Copy link
Collaborator

beniz commented Apr 8, 2022

Hello @phbasler Thanks for asking. Would you be interested in taking ownership of that conan package, and even help around a bit more ? If it requires that we grant you more access to the this repository, I guess this could be arranged.

@nikohansen Hi! Though waiting for @phbasler approval, would that be OK to add Philipp to maintainers ?

Again my apologies for the lag with my reponses, my plate is full these days!

@phbasler
Copy link
Contributor Author

phbasler commented Apr 8, 2022

Hi @beniz ,

Sure, I can help with that part. I don't know if I have time to help with code specific questions, but I can help with setup related parts. I play a lot with different CIs on https://github.com/phbasler/BSMPT at the moment (codecov, automated tests on windows/mac/ubuntu, lgtm, benchmarking) and could also bring those parts here if you want to add some CIs for PRs.

And no worry about the response time. This is nothing urgent for me.

@phbasler
Copy link
Contributor Author

phbasler commented May 1, 2022

@beniz After you approve the 3 PRs (#234 , #235 , #236 ) it would be useful if you could make a new release (0.10.1 is enough), so that it is easier to create a conan package for the release with the adjustments for conan through the PRs.

@Luk0r
Copy link

Luk0r commented Mar 22, 2023

Any news on this? I checked conan center and didn't find the package.

@beniz
Copy link
Collaborator

beniz commented Mar 22, 2023

Ooops, this got lost in my board of tasks... Let's see if I can fix this.

@phbasler
Copy link
Contributor Author

@Luk0r In case you can help:
I have started it at conan-io/conan-center-index#24202 but some profiles with conan 1 are not working.

@phbasler
Copy link
Contributor Author

@beniz So the conan package is now building and is awaiting for their approval.
FYI I had to apply a patch file for it to work. This is a subset of the changed I suggested with #234 .
The diff file is in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants