Adding CMake 3.4 check

.ci/azure-build.yml

@@ -2,7 +2,7 @@ steps:
 
 - task: CMake@1
   inputs:
-    cmakeArgs: .. -DCLI11_WARNINGS_AS_ERRORS=ON -DCLI11_SINGLE_FILE=$(cli11.single) -DCLI11_CXX_STD=$(cli11.std) -DCLI11_SINGLE_FILE_TESTS=$(cli11.single) -DCMAKE_BUILD_TYPE=$(cli11.build_type) $(cli11.options)
+    cmakeArgs: .. -DCLI11_WARNINGS_AS_ERRORS=ON -DCLI11_SINGLE_FILE=$(cli11.single) -DCMAKE_CXX_STANDARD=$(cli11.std) -DCLI11_SINGLE_FILE_TESTS=$(cli11.single) -DCMAKE_BUILD_TYPE=$(cli11.build_type) $(cli11.options)
   displayName: 'Configure'
 
 - script: cmake --build .

.ci/make_and_test.sh

@@ -8,7 +8,7 @@ set -evx
 
 mkdir -p build
 cd build
-cmake .. -DCLI11_WARNINGS_AS_ERRORS=ON -DCLI11_SINGLE_FILE=ON -DCLI11_CXX_STD=$STD -DCLI11_SINGLE_FILE_TESTS=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER_LAUNCHER=ccache $@
+cmake .. -DCLI11_WARNINGS_AS_ERRORS=ON -DCLI11_SINGLE_FILE=ON -DCMAKE_CXX_STANDARD=$STD -DCLI11_SINGLE_FILE_TESTS=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER_LAUNCHER=ccache $@
 cmake --build . -- -j2
 
 set +evx

.github/actions/cmake_config/Dockerfile

@@ -0,0 +1,16 @@
+FROM ubuntu:18.04
+
+RUN apt-get update \
+ && apt-get install -y --no-install-recommends \
+        g++=4:7.4.0-1ubuntu2.3 \
+        wget=1.19.4-1ubuntu2.2 \
+        libidn11=1.33-2.1ubuntu1.2 \
+        ca-certificates=20180409 \
+        make=4.1-9.1ubuntu1 \
+        git=1:2.17.1-1ubuntu0.5 \
+ && apt-get clean \
+ && rm -rf /var/lib/apt/lists/*
+
+COPY entrypoint.sh /entrypoint.sh
+
+ENTRYPOINT ["/entrypoint.sh"]

.github/actions/cmake_config/action.yml

@@ -0,0 +1,16 @@
+description: 'Test out a bare bones configuration with a CMake version'
+inputs:
+  version:
+    description: 'The full version of CMake to check'
+    required: true
+  options:
+    description: 'The CMake configuration options'
+    required: false
+    default: ""
+name: 'Configure with CMake'
+runs:
+  using: 'docker'
+  image: 'Dockerfile'
+  args:
+    - ${{ inputs.version }}
+    - ${{ inputs.options }}

.github/actions/cmake_config/entrypoint.sh

@@ -0,0 +1,23 @@
+#!/bin/bash -l
+
+set -ex
+
+mkdir -p cmake_dir
+mkdir -p build_tmp
+mkdir -p cmake_sources
+rm -rf cmake_dir/* build_tmp/*
+
+v=$1
+fn=cmake-$v-Linux-x86_64.tar.gz
+
+if [ ! -f cmake_souces/$fn ]; then
+    wget -qO cmake_sources/$fn "https://cmake.org/files/v${v%.*}/$fn"
+fi
+
+tar -xzf cmake_sources/$fn --strip-components=1 -C $PWD/cmake_dir
+
+export PATH=$PWD/cmake_dir/bin:$PATH
+
+cmake --version
+
+cd build_tmp && cmake .. $2

.github/workflows/tests.yml

@@ -28,14 +28,88 @@ jobs:
     runs-on: ubuntu-latest
     container: nvidia/cuda:10.2-devel-ubuntu18.04
     steps:
-      - uses: actions/checkout@v1
-        with:
-          submodules: true
-      - name: Add wget
-        run: apt-get update && apt-get install -y wget
-      - name: Install Modern CMake
-        run: wget -qO- "https://cmake.org/files/v3.16/cmake-3.16.0-Linux-x86_64.tar.gz" | tar --strip-components=1 -xz -C /usr/local
-      - name: Configure
-        run: cmake -S . -B build -DCLI11_CUDA_TESTS=ON
-      - name: Build
-        run: cmake --build build
+    - uses: actions/checkout@v1
+      with:
+        submodules: true
+    - name: Add wget
+      run: apt-get update && apt-get install -y wget
+    - name: Install Modern CMake
+      run: wget -qO- "https://cmake.org/files/v3.16/cmake-3.16.0-Linux-x86_64.tar.gz" | tar --strip-components=1 -xz -C /usr/local
+    - name: Configure
+      run: cmake -S . -B build -DCLI11_CUDA_TESTS=ON
+    - name: Build
+      run: cmake --build build -j2
+
+  cmake-config:
+    name: CMake config check
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+      with:
+        submodules: true
+    - name: CMake 3.4
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.4.3
+    - name: CMake 3.5
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.5.2
+      if: success() || failure()
+    - name: CMake 3.6
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.6.3
+      if: success() || failure()
+    - name: CMake 3.7
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.7.2
+      if: success() || failure()
+    - name: CMake 3.8
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.8.2
+      if: success() || failure()
+    - name: CMake 3.9
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.9.6
+      if: success() || failure()
+    - name: CMake 3.10
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.10.3
+      if: success() || failure()
+    - name: CMake 3.11 (full)
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.11.4
+        options: -DCLI11_SANITIZERS=ON -DCLI11_BUILD_EXAMPLES_JSON=ON
+      if: success() || failure()
+    - name: CMake 3.12
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.12.4
+      if: success() || failure()
+    - name: CMake 3.13
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.13.5
+      if: success() || failure()
+    - name: CMake 3.14
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.14.7
+      if: success() || failure()
+    - name: CMake 3.15
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.15.6
+      if: success() || failure()
+    - name: CMake 3.16 (full)
+      uses: ./.github/actions/cmake_config
+      with:
+        version: 3.16.2
+        options: -DCLI11_SANITIZERS=ON -DCLI11_BUILD_EXAMPLES_JSON=ON
+      if: success() || failure()

.gitmodules

@@ -1,9 +1,3 @@
 [submodule "extern/googletest"]
 	path = extern/googletest
 	url = ../../google/googletest.git
-[submodule "extern/sanitizers"]
-	path = extern/sanitizers
-	url = ../../arsenm/sanitizers-cmake
-[submodule "extern/json"]
-	path = extern/json
-	url = ../../nlohmann/json.git