Bug fix for issue 369. #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion state after it had executed the callback and reset the results vector, allowing the possibility of an empty results getting passed to some conversions functions.
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3397 3398 +1
=====================================
+ Hits 3397 3398 +1
Continue to review full report at Codecov.
|
henryiii
approved these changes
Dec 17, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default_val call was not resetting the option state after it had executed the callback and reset the results vector, allowing the possibility of an empty results getting passed to some conversions functions.
If merged this pull request will add the test described in issue #369 and a fix to the default_val function which correctly resets the option state after evaluating the internal callback.
Closes #369.