Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #336

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Fix CI #336

merged 2 commits into from
Oct 24, 2019

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 24, 2019 •
edited
Loading

  • Adding pre-commit as the recommended way to run formatting
  • Use github actions as the format checker
  • Use Python 3 to install conan

@codecov
Copy link

codecov bot commented Oct 24, 2019 •
edited
Loading

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #336   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3038   3048   +10     
=====================================
+ Hits         3038   3048   +10
Impacted Files Coverage Δ
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <0%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ecce8f...f55e0cb. Read the comment docs.

@henryiii henryiii force-pushed the henryiii-cifix branch 3 times, most recently from dc35f7e to f55e0cb Compare October 24, 2019 22:50
@henryiii
Adding github actions, precommit, and fix for travis
f55e0cb 
Adding pre-commit files

GitHub actions, and Python 3 on Travis

Fix missing pip

Adding pre-commit instructions

Using bionic

Fix

Drop extra parts, add pip

Setuptools
@henryiii henryiii merged commit 4376990 into master Oct 24, 2019
@henryiii henryiii deleted the henryiii-cifix branch October 24, 2019 23:07
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
@zadjii-msft zadjii-msft mentioned this pull request Dec 13, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
1 participant
@henryiii