Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #298, resetting config option #301

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix #298, resetting config option #301

merged 1 commit into from
Jul 25, 2019

Conversation

henryiii
Copy link
Collaborator

Add a test, and make sure this gets reset.

@henryiii henryiii added the bug label Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@68c8b1b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #301   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     12           
  Lines             ?   2884           
  Branches          ?      0           
=======================================
  Hits              ?   2884           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c8b1b...4485fbc. Read the comment docs.

@henryiii henryiii merged commit f583e5b into master Jul 25, 2019
@henryiii henryiii deleted the henryiii-confreset branch July 25, 2019 20:16
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant