-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: Basic meson support #299
Conversation
The Azure CI errors are unrelated. |
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2880 2880
=====================================
Hits 2880 2880 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2887 2887
=====================================
Hits 2887 2887 Continue to review full report at Codecov.
|
I plan to fix the CI then merge this, probably in the next few days... |
Could you rebase and force push (or just merge) with current master? Thanks! |
With this patch, CLI11 can be used as a meson subproject: http://mesonbuild.com/Subprojects.html However, CMake is still required for testing and installation. The current meson.build is not a complete replacement.
Done. Let's hope the CI gets green :) |
How hard would it be to add a new job to Azure to run meson with a little example project that uses this? (Not very familiar with Meson) |
Depends. That project would have to include the CLI11 repository in its's subproject directory. So, copying the CLI11 repo in the CI or a seperate repository would be required. Also python (>= 3.5), meson and ninja would be required on all images. The actual project would be fairly simple and easy to provide, however, implementing this in the CI will probably the most difficult part. |
Could you provide the example project? I can probably set up the ci pretty easily. At the minimum, I could do a |
Adding it to this PR should work. Do you have any preferences where to put the test? |
In a folder in the test folder. If it looks really useful as an example it might eventually be moved into the examples folder. |
Added the test project. Also a minimal README.md, in case this will be a meson example. |
This does not add the C++ standard setting, so it fails if you build on LLVM (or probably GCC < 6).
(macOS) |
Should be fixed now (defaults to |
I believe it does not pick up the default (should be minimum...) C++ standard from a target. Not sure why this is supposed to be better than CMake... But, okay. |
It also does not regenerate correctly and has to have the build directory removed before it picks up the change... |
I mean, the C++ std is now |
Yes, but I would have thought it would have made it C++11 because the sub-project was C++11, but that's not too bad. When I ran meson build again, it said that ninja would regenerate if necessary, but it did not because the build file changed. Just seems like usability issues. |
Should be ready to merge. Would you like it in examples instead of tests? I'd be okay with that. |
I would like to keep it in tests for now. It is a bit minimal for an example in the current state. Maybe I do a new PR in the future with a bit more content |
Okay. Thanks! |
With this patch, CLI11 can be used as a meson
subproject: http://mesonbuild.com/Subprojects.html
However, CMake is still required for testing and
installation. The current meson.build is not a
complete replacement.