Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow immediate_callback on the main app #292

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jun 13, 2019

Allow immediate_callback on the main app to run the main app callback prior to named subcommand callbacks, and reflect this change in the a new test and docs.

See gitter discussion

… prior to named subcommand callbacks, and reflect this change in the a new test and docs.
@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #292   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2880   2886    +6     
=====================================
+ Hits         2880   2886    +6
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73aa158...fea6aa5. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #292   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2880   2886    +6     
=====================================
+ Hits         2880   2886    +6
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73aa158...345db5f. Read the comment docs.

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Henry Schreiner <HenrySchreinerIII@gmail.com>
@henryiii henryiii merged commit 68c8b1b into CLIUtils:master Jul 25, 2019
@phlptp phlptp deleted the immediate_callback_on_main_app branch September 4, 2019 13:33
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants