Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail to build due to missing <cstdint> with 2.4.0 #993

Closed
ionenwks opened this issue Feb 5, 2024 · 0 comments · Fixed by #996
Closed

Tests fail to build due to missing <cstdint> with 2.4.0 #993

ionenwks opened this issue Feb 5, 2024 · 0 comments · Fixed by #996

Comments

@ionenwks
Copy link

ionenwks commented Feb 5, 2024 •
edited
Loading

Assume my currently used toolchain/libraries (on Gentoo Linux) removes a transitively-used header (haven't dug into exact cause) if CI here hasn't caught it.

include/CLI/impl/StringTools_inl.hpp has several use of uint32_t but does not include cstdint that I can see, including it fixes it for me.

/tmp/portage/dev-cpp/cli11-2.4.0/work/CLI11-2.4.0/include/CLI/impl/StringTools_inl.hpp:218:19: error: 'uint32_t' in namespace 'std' does not name a type; did you mean 'wint_t'?
  218 | CLI11_INLINE std::uint32_t hexConvert(char hc) {
      |                   ^~~~~~~~
      |                   wint_t
@henryiii henryiii mentioned this issue Feb 5, 2024
Merged
henryiii added a commit that referenced this issue Feb 5, 2024
@henryiii
fix: transiative include issue (#996)
30ead5d 
Fix #993. I tried include-what-you-use, but it reports too much stuff to
be able to pick out what's missing very effectively.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: transiative include issue CLIUtils/CLI11
1 participant
@ionenwks