Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack and version number #748

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Update Icepack and version number #748

merged 2 commits into from
Aug 4, 2022

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Aug 4, 2022

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack and version number
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Underway, will update soon
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig
Update Icepack
b8f38d4 
Update Version
@apcraig
Copy link
Contributor Author

apcraig commented Aug 4, 2022

I ran various test suites on cheyenne and think we're in good shape now. Will merge when GHActions completes.

@apcraig apcraig merged commit 5a1701c into CICE-Consortium:main Aug 4, 2022
dabail10 pushed a commit to ESCOMP/CICE that referenced this pull request Oct 4, 2022
@apcraig @dabail10
Update Icepack and version number (CICE-Consortium#748)
214856a 
* Update Icepack
Update Version

* Set visc_method='avg_strength' for gridCD to avoid some aborts
Fix a few bugs in the test suite lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabail10 dabail10 dabail10 approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apcraig @eclare108213 @dabail10