Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icepack to 3cb1746a202615044e, deprecate 0layer and cesmponds #743

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Update icepack to 3cb1746a202615044e, deprecate 0layer and cesmponds #743

merged 1 commit into from
Jul 31, 2022

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 31, 2022 •
edited
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Update icepack to 3cb1746a202615044e, deprecate 0layer and cesmponds
  • Developer(s):
    eclare108213, dabail10
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Full test suite on cheyenne is as expected, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#4df8f30678165d2443a80c9b582889cbee0816e6
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial, several features are deprecated, they no longer work so several test cases were modified. Otherwise, this is bit-for-bit.
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes, changes several test cases
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig
Copy link
Contributor Author

apcraig commented Jul 31, 2022

Test results are as expected. This brings CICE up to date with the 4 deprecation PRs, 0-layer and cesmponds in Icepack and CICE.

@apcraig apcraig merged commit c6470cf into CICE-Consortium:main Jul 31, 2022
@phil-blain phil-blain mentioned this pull request Aug 18, 2022
Closed
dabail10 pushed a commit to ESCOMP/CICE that referenced this pull request Oct 4, 2022
@apcraig @dabail10
Update icepack to 3cb1746a202615044e (CICE-Consortium#743)
ea7ecd4 
Bring in deprecated 0-layer and cesmponds changes in Icepack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 Awaiting requested review from eclare108213

@dabail10 dabail10 Awaiting requested review from dabail10

Assignees
No one assigned
Labels
Icepack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apcraig