Update mct/cesm1 driver, fix ss_tlt implementation #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mct/cesm1 driver for snow mods and other recent changes Remove USE_NETCDF cpp in io_pio2/ice_restart.F90, not needed or correct
eclare108213
approved these changes
Jun 2, 2022
limited situations where we want to ensure bit-for-bit across the seam, but do NOT want to update the halo in general. In particular, this is needed for UAREA during initialization. UAREA is explicitly computed in the halo to avoid missing data. In some cases, uarea computed independently along the seam in the halo points results in roundoff level differences. This will produce a small error in the simulation but more important, breaks the symmetry across the seam. In that case, we just want to sync up the halo, but we do NOT want to update the independent UAREA halo computations elsewhere because of land block elimination and other situations where blocks have no neighbors.
DeniseWorthen
approved these changes
Jun 2, 2022
|
I reran the full test suite on cheyenne after adding the tripoleOnly option to the haloupdate call. Everything is still bit-for-bit. I also tested the code in UFS, which highlighted the issue and this seems to fix a problem we saw there. |
eclare108213
approved these changes
Jun 3, 2022
16 tasks
dabail10
pushed a commit
to ESCOMP/CICE
that referenced
this pull request
Oct 4, 2022
* Update ss_tltx, ss_tlty averaging/usage in evp, eap, vp Update mct/cesm1 driver for snow mods and other recent changes Remove USE_NETCDF cpp in io_pio2/ice_restart.F90, not needed or correct * Add tripoleOnly flag to ice_HaloUpdate2DR8. This is needed in very limited situations where we want to ensure bit-for-bit across the seam, but do NOT want to update the halo in general. In particular, this is needed for UAREA during initialization. UAREA is explicitly computed in the halo to avoid missing data. In some cases, uarea computed independently along the seam in the halo points results in roundoff level differences. This will produce a small error in the simulation but more important, breaks the symmetry across the seam. In that case, we just want to sync up the halo, but we do NOT want to update the independent UAREA halo computations elsewhere because of land block elimination and other situations where blocks have no neighbors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Update mct/cesm1 driver, fix ss_tlt implementation
apcraig, deniseworthen, dabail10
Bit-for-bit in CICE standalone, full test suites run on cheyenne and narwhal. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#74632f4de904bf890f2a490e5ea3df17f799081a
Update ss_tltx, ss_tlty averaging/usage in evp, eap, vp
Update mct/cesm1 driver for snow mods and other recent changes
Remove USE_NETCDF cpp in io_pio2/ice_restart.F90, not needed or correct