Add lcov code coverage tool #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallard77
approved these changes
Jun 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Add lcov code coverage tool and minor refactor of coverage scripts
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
ran several tests with coverage turned on, verifies it updates the following website, https://apcraig.github.io/
no source code was changed, ran a quick suite on cheyenne with 3 compilers to confirm things are working, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#ea01b978fcc788fa021d9ea789dc440cc724993b
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
Updates the scripts implementation and adds lcov tool.
"--coverage" turns on lcov analysis, prior to this PR it activated the codecov analysis tool. The codecov tool is still available and can be run manually.
need to have write permissions to github.com/apcraig/apcraig.github.io to write results to the web site. This site could/should be moved into the Consortium once there's general agreement it should live there. I am also happy to provide write access to several people and for it to continue to live under apcraig.
Adds a badge for the lcov results, will need to check it's working OK once merged.
Cleans up the /bin/csh implementation, removing a space.