Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noaa machines and minor cleanup from RG #319

Merged
merged 1 commit into from
May 31, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 30, 2019

Add NOAA machines and some cleanup, from @rgrumbine, see #317
Additions to run regression tests on NWS operational system 'phase2' and NOAA R+D system 'theia':

  • Developer(s): rgrumbine, tcraig

  • Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit

  • Does this PR create or have dependencies on Icepack or any other models? N

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

  • Other Relevant Details:

Though present, the theia_gnu and theia_pgi configurations have not been confirmed to pass the full regression suite.

This was a redo of PR #317 which caused problems due to some issues with the Icepack submodule setup. This is exactly f9ae148 from @rgrumbine's fork with the icepack submodule changes not brought over and the gitignore mod not included. It also includes few other mods to get rid of tabs in a few files that were noticed the sandbox was reviewed before committing.

@apcraig apcraig self-assigned this May 30, 2019
@apcraig
Copy link
Contributor Author

apcraig commented May 30, 2019

I am running a quick test on conrad as well. I will report those results when I have them. But wanted to give @rgrumbine a chance to review this PR and for travis to do it's thing concurrently.

@apcraig
Copy link
Contributor Author

apcraig commented May 30, 2019

I am going to close #317 at this point.

@rgrumbine
Copy link
Contributor

Thanks Tony.

Copy link
Contributor

@rgrumbine rgrumbine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Tony. All looks good, and I've re-forked my copy of CICE.

@apcraig apcraig merged commit d014f4b into CICE-Consortium:master May 31, 2019
@apcraig
Copy link
Contributor Author

apcraig commented May 31, 2019

Just to add, full test suite on conrad showed no problems.

@apcraig apcraig mentioned this pull request May 31, 2019
@apcraig apcraig deleted the rgport branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants