Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected k1 parameter for grounding scheme #206

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

JFLemieux73
Copy link
Contributor

[Remove this and add a short summary line]:

  • Developer(s): JF Lemieux

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? NA

  • Please include the link to test results or paste the summary block from the bottom of the testing output below.

  • Does this PR create or have dependencies on Icepack or any other models? N

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.

  • Other Relevant Details:

k1 was 20. It is now set to the rigth value (k1=8).

I also removed a comment in ice_dyn_evp.F90 saying that we save the replacement pressure for principal_stress (not used anymore).

@apcraig apcraig requested review from apcraig and eclare108213 and removed request for apcraig October 13, 2018 12:51
@apcraig
Copy link
Contributor

apcraig commented Oct 13, 2018

I'm fine with this change, but just want to make sure @eclare108213 has a quick look in case we need to defer or otherwise. I assume this will change answers for at least a couple tests and that we don't need to run the qc or otherwise beforehand.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, fixing a bug.
@JFLemieux73 we don't have to do this now, but does it make sense to have these parameters in the namelist?

@eclare108213 eclare108213 merged commit b344acc into CICE-Consortium:master Oct 14, 2018
@JFLemieux73 JFLemieux73 deleted the correct_k1 branch January 26, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants