Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcdf metadata is not right for some C grid output variables #789

Closed
JFLemieux73 opened this issue Nov 14, 2022 · 0 comments · Fixed by #790
Closed

netcdf metadata is not right for some C grid output variables #789

JFLemieux73 opened this issue Nov 14, 2022 · 0 comments · Fixed by #790
Assignees
@apcraig
Labels
IO Type: Bug

Comments

@JFLemieux73
Copy link
Contributor

B grid sigP is located at the U point. ncdump -h gives:

sigP:coordinates = "ULON ULAT time" ;
sigP:cell_measures = "area: uarea" ;
sigP:comment = "sigP is instantaneous, on U grid (NE corner values)" ;

However, for the C grid, sigP is at the T point. ncdump -h gives:

sigP:coordinates = "ULON ULAT time" ;
sigP:cell_measures = "area: uarea" ;
sigP:comment = "sigP is instantaneous, on T grid" ;

ULON, ULAT and uarea are not correct.

sig1 and sig2 also have similar problems. Also consider issue #707 when fixing this.
@apcraig apcraig self-assigned this Nov 14, 2022
apcraig added a commit to apcraig/CICE that referenced this issue Nov 15, 2022
@apcraig
Rename cicedynB to cicedyn, update test suites
99f80e6 
- Rename cicedynB directory to cicedyn (See CICE-Consortium#660)
  - Add softlink for cicedynB
  - Update path in cice.build
  - Update documentation
- Fix sig1, sig2, sigP grid on history file (See CICE-Consortium#789)
- Fix Fortran warning messages for long lines
- Fix test suite order in cice.setup
- Update test suites to reduce bfbcomp failures due to time outs
  - Add tests to first_suite to help
- Add dyneap and dynpicard decomp tests, add set_nml.dyneap
- Add TAB check in github actions in all .F90 and .c files
  github actions will fail if source files have TABs
@apcraig apcraig mentioned this issue Nov 15, 2022
Merged
18 tasks
apcraig added a commit to apcraig/CICE that referenced this issue Nov 17, 2022
@apcraig
Rename cicedynB to cicedyn, update test suites
31d119b 
- Rename cicedynB directory to cicedyn (See CICE-Consortium#660)
  - Add softlink for cicedynB
  - Update path in cice.build
  - Update documentation
- Fix sig1, sig2, sigP grid on history file (See CICE-Consortium#789)
- Fix Fortran warning messages for long lines
- Fix test suite order in cice.setup
- Update test suites to reduce bfbcomp failures due to time outs
  - Add tests to first_suite to help
- Add dyneap and dynpicard decomp tests, add set_nml.dyneap
- Add TAB check in github actions in all .F90 and .c files
  github actions will fail if source files have TABs
apcraig added a commit that referenced this issue Nov 18, 2022
@apcraig
Rename cicedynB to cicedyn, update test suites (#790)
9104a8c 
* Rename cicedynB to cicedyn, update test suites

- Rename cicedynB directory to cicedyn (See #660)
  - Add softlink for cicedynB
  - Update path in cice.build
  - Update documentation
- Fix sig1, sig2, sigP grid on history file (See #789)
- Fix Fortran warning messages for long lines
- Fix test suite order in cice.setup
- Update test suites to reduce bfbcomp failures due to time outs
  - Add tests to first_suite to help
- Add dyneap and dynpicard decomp tests, add set_nml.dyneap
- Add TAB check in github actions in all .F90 and .c files
  github actions will fail if source files have TABs

* Remove tabs

* Update documentation

* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apcraig apcraig

Labels
IO Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename cicedynB to cicedyn, update test suites apcraig/CICE
2 participants
@apcraig @JFLemieux73