Skip to content

Commit

Permalink
Apply facebook#18278 to fix TextInput.clear() bug
Browse files Browse the repository at this point in the history
  • Loading branch information
magicien committed Mar 14, 2018
1 parent 7be3d1c commit ab370f3
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
22 changes: 22 additions & 0 deletions Libraries/Text/TextInput/RCTBaseTextInputView.m
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,28 @@ - (void)setReactBorderInsets:(UIEdgeInsets)reactBorderInsets
[self setNeedsLayout];
}

- (NSString *)text
{
return [self attributedText].string;
}

- (void)setText:(NSString *)text
{
if (self.attributedText.length > 0) {
//copy the attributes
NSRange range = NSMakeRange(self.attributedText.length-1, self.attributedText.length);
NSDictionary *attributes = [self.attributedText attributesAtIndex:0 effectiveRange:&range];
NSMutableAttributedString *newString = [[NSMutableAttributedString alloc] initWithString:text attributes:attributes];
NSMutableAttributedString *primaryStringMutable = [[NSMutableAttributedString alloc] initWithAttributedString:self.attributedText];

//change the string
[primaryStringMutable setAttributedString:newString];
[self setAttributedText:[[NSAttributedString alloc] initWithAttributedString:primaryStringMutable]];
} else {
[self setAttributedText:[[NSAttributedString alloc] initWithString: text]];
}
}

- (NSAttributedString *)attributedText
{
return self.backedTextInputView.attributedText;
Expand Down
1 change: 1 addition & 0 deletions Libraries/Text/TextInput/RCTBaseTextInputViewManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ @implementation RCTBaseTextInputViewManager
RCT_EXPORT_VIEW_PROPERTY(onSelectionChange, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(onTextInput, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(onScroll, RCTDirectEventBlock)
RCT_EXPORT_VIEW_PROPERTY(text, NSString)

RCT_EXPORT_VIEW_PROPERTY(mostRecentEventCount, NSInteger)

Expand Down

0 comments on commit ab370f3

Please sign in to comment.