Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning if SUMMA performs a relative humidity correction? #507

Open
wknoben opened this issue Mar 31, 2022 · 1 comment
Open

Add a warning if SUMMA performs a relative humidity correction? #507

wknoben opened this issue Mar 31, 2022 · 1 comment
Labels
enhancement usability changes designed to improve the usability of SUMMA (ie ease of running for different applications)

Comments

@wknoben
Copy link
Collaborator

wknoben commented Mar 31, 2022

Feature Requests

! compute relative humidity (-)
relhum = SPHM2RELHM(spechum, airpres, airtemp)
! if relative humidity exceeds saturation, then set relative and specific humidity to saturation
if(relhum > 1._rkind)then
relhum = 1._rkind
spechum = RELHM2SPHM(relhum, airpres, airtemp)
end if

Might be helpful to users if this correction also prints a warning, so that it becomes easier to track what happens to the provided forcing data

@wknoben wknoben added enhancement usability changes designed to improve the usability of SUMMA (ie ease of running for different applications) labels Mar 31, 2022
@andywood
Copy link
Collaborator

andywood commented Apr 1, 2022

I support adding a warning if it can be included under a --verbose option for output. Even in that case, it might be good to restrict or summarize it in some way so that it doesn't have the potential to print every timestep and every hru, which would be unnecessary. Perhaps create an end-of-run warning message listing the first 10 occurrences (hru, date, values).

SUMMA could even write such warnings to a file rather than merge them with screen output -- such as the 'runinfo' file which is created at the start to make sure the output directory exists. Rather than close that file, use it to collect certain types of warnings that a user could see if they wanted to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement usability changes designed to improve the usability of SUMMA (ie ease of running for different applications)
Projects
None yet
Development

No branches or pull requests

2 participants