Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slopeTypeIndex attribute and associated code #471

Open
wknoben opened this issue Jun 17, 2021 · 0 comments
Open

Remove slopeTypeIndex attribute and associated code #471

wknoben opened this issue Jun 17, 2021 · 0 comments
Labels

Comments

@wknoben
Copy link
Collaborator

wknoben commented Jun 17, 2021

Feature Requests

  • Description of feature
    The attribute file requires slopeTypeIndex to be specified as a result of using the Noah-mp code for lookup tables. This variable does not appear to be used anywhere in the code (anymore?). Removing the need to specify this variable will clean up the code.

  • Description of the problem the feature addresses
    Unclear code, need to specify a variable that serves no purpose.

  • Will the proposed feature be backward compatible?
    Tentatively yes, assuming that it is OK if an attributes.nc file contains more variables than the code looks for. If so, existing attributes.nc files that contain a slopeTypeIndex value should still function after this variable has been removed from the code.

  • Will the proposed feature change the science results of SUMMA?
    No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant