Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file reading for trial parameters file #237

Open
bartnijssen opened this issue Sep 11, 2017 · 1 comment
Open

Improve file reading for trial parameters file #237

bartnijssen opened this issue Sep 11, 2017 · 1 comment

Comments

@bartnijssen
Copy link
Collaborator

https://github.com/NCAR/summa/blob/develop/build/source/engine/read_param.f90#L175-L182

Currently the code has a hard wired name for the variable describing the hru ID (hruId), but this is actually different than what is in the test suite (which uses hruIndex). I think that actually means that the index in the file is not used and the code should not continue in that case, because the default is to "expect HRUs to be in the same order as the local attributes". However, the user may not have full control over this in NetCDF files and there is no reason to make this assumption. The risk here is that hru and gru attributes are assigned to the wrong hrus and grus.

We should require a specific index variable (for example hruId and gruId and then use these values to map the values to the correct HRUs and GRUs rather than relying on an assumed order. If the index variable is not present, then the program should FAIL.

@bartnijssen
Copy link
Collaborator Author

See also #253 : The part in common is that we do not search for the correct hruId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant