Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect hardcoded literals into constants #118

Open
bartnijssen opened this issue Mar 28, 2016 · 2 comments
Open

Collect hardcoded literals into constants #118

bartnijssen opened this issue Mar 28, 2016 · 2 comments
Labels
cleanup infrastructure
Milestone
someday

Comments

@bartnijssen
Copy link
Collaborator

Replace hardcoded literals, such as

character(LEN=256) by character(LEN=STR_SIZE)
12 by MONTHS_P_PYR

etc. to improve readability and maintainability
@bartnijssen bartnijssen mentioned this issue Mar 28, 2016
Merged
@martynpclark
Copy link
Collaborator

Also the notPopulatedYet strings

@martynpclark
Copy link
Collaborator

Also nBands and nTimeDelay

@bartnijssen bartnijssen mentioned this issue Apr 1, 2016
Merged
@bartnijssen bartnijssen mentioned this issue Apr 12, 2016
Merged
@bartnijssen bartnijssen mentioned this issue Apr 22, 2016
Merged
@bartnijssen bartnijssen added this to the someday milestone Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup infrastructure
Projects
None yet
Milestone
someday
Development

No branches or pull requests
2 participants
@bartnijssen @martynpclark