Dpdk: Add DPDK mbuf alignment to max_packet_size calculation #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the calculation of the maximum packet size to incorporate DPDK mbuf alignment, addressing MTU handling issues and preventing mbuf allocation failures.
- Introduces a constant for DPDK mbuf alignment (DPDK_MBUF_ALIGN)
- Updates max_packet_size calculation using RTE_ALIGN_CEIL for alignment compliance
Comments suppressed due to low confidence (1)
src/plugins/input/dpdk/src/dpdkDevice.cpp:173
- [nitpick] If DPDK_MBUF_ALIGN is likely to be reused in other parts of the project, consider moving it to a more central configuration or header file to ensure consistency.
= RTE_ALIGN_CEIL(m_mtuSize + RTE_ETHER_HDR_LEN + VLAN_HDR_LEN, DPDK_MBUF_ALIGN);
| void DpdkDevice::initMemPools(uint16_t memPoolSize) | ||
| { | ||
| constexpr int MEMPOOL_CACHE_SIZE = 256; | ||
| constexpr int VLAN_HDR_LEN = 4; |
There was a problem hiding this comment.
[nitpick] Consider adding a comment explaining why DPDK_MBUF_ALIGN is set to 1024 and its relevance to mbuf alignment requirements.
Suggested change
| constexpr int VLAN_HDR_LEN = 4; | |
| constexpr int VLAN_HDR_LEN = 4; | |
| // DPDK_MBUF_ALIGN ensures that mbufs are aligned to 1024 bytes, which is required | |
| // for optimal performance and compatibility with DPDK and hardware requirements. |
Lukas955
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues related to incorrect MTU handling and associated mbuf allocation failures.