optimize libload #648
Draft
optimize libload #648
+113
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZERICO2005
commented
Oct 11, 2025
src/libload/libload.asm
Outdated
Comment on lines
216
to
226
| .no_match: | ||
| pop de | ||
| ld hl, (end_arc_lib_locs) | ||
| call ti.CpHLDE ; have we reached the end of the table? | ||
| or a, a | ||
| sbc hl, de ; have we reached the end of the table? | ||
|
|
||
| push af | ||
| ex de, hl | ||
| ld de, 15 ; size of search entry (9=name, 3=ram ptr, 3=arc vec ptr) | ||
| ld hl, 15 ; size of search entry (9=name, 3=ram ptr, 3=arc vec ptr) | ||
| add hl, de | ||
| ex de, hl ; end of the extraction table? | ||
| pop af |
There was a problem hiding this comment.
Proof that this transformation is valid
; Original
ld de, Y
ld hl, X
or a, a
sbc hl, de ; HL = X - Y, DE = Y
add hl, de ; HL = X , DE = Y
ex de, hl ; HL = Y , DE = X
ld de, 15 ; HL = Y , DE = 15
add hl, de ; HL = Y + 15, DE = 15
ex de, hl ; HL = 15, DE = Y + 15
pop hl ; HL = ?, DE = Y + 15
; Optimized
ld de, Y
ld hl, X
or a, a
sbc hl, de ; HL = X - Y, DE = Y
ld hl, 15 ; HL = 15, DE = Y
add hl, de ; HL = Y + 15, DE = Y
ex de, hl ; HL = Y, DE = Y + 15
pop hl ; HL = ?, DE = Y + 15
ZERICO2005
force-pushed
the
opt_libload
branch
from
b83e795 to
c866c34
Compare
ZERICO2005
had a problem deploying
to
Autotester
GitHub Actions
Failure
ZERICO2005
had a problem deploying
to
Autotester
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied some optimizations to libload to reduce size.