Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lineage Tracking in FHIRReceiver Function #16148

Open
2 tasks
arnejduranovic opened this issue Oct 8, 2024 · 1 comment
Open
2 tasks

Update Lineage Tracking in FHIRReceiver Function #16148

arnejduranovic opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
microservice Tickets that are required to properly support the microservice arch platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality

Comments

@arnejduranovic
Copy link
Collaborator

arnejduranovic commented Oct 8, 2024

User Story

As the owner of the ReportStream Architecture,
I want the FHIRReceiver pipeline step to implement lineage tracking correctly,
so that FHIRReceiver behaves the same as other UP steps in this regard.

Description/Use Case

CONTEXT: Ticket #16011 was created following the initial FHIRReceiver implementation and the QueueMessage followup to rethink how the "submission specific" events should be designed. Upon further investigation, it has been decided Ticket #16011 should be closed and instead the FHIRReceiver should be updated so that a new event is not required. The initial implementation deviated from the normal report and lineage creation/handling and should be brought back in line. Once this is done, the submission specific events can go away and reuse the currently existing Report events.

The goal of this ticket is to:

  • Create an empty report with child lineage when there is a processing error (everywhere there is sendSubmissionProcessingError currently in FHIRReceiver)
  • sendSubmissionProcessingError should be removed entirely and replaced with sendReportProcessingError
  • verify kdoc of getSender is correct for "The sender, or null if the sender was not found or is inactive." and update the else block to match

Risks/Impacts/Considerations

Dev Notes

Acceptance Criteria

  • FHIRReceiver creates an empty report when an error is encountered
  • Events updated accordingly
@arnejduranovic arnejduranovic added platform Platform Team ready-for-refinement Ticket is a point where we can productively discuss it labels Oct 8, 2024
@MichaelEsuruoso
Copy link
Collaborator

@arnejduranovic arnejduranovic added the microservice Tickets that are required to properly support the microservice arch label Oct 8, 2024
@MichaelEsuruoso MichaelEsuruoso added tech-debt Anything that is purely a technical issue and does not affect functionality and removed ready-for-refinement Ticket is a point where we can productively discuss it labels Oct 8, 2024
@mkalish mkalish assigned mkalish and unassigned mkalish Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
microservice Tickets that are required to properly support the microservice arch platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Development

No branches or pull requests

3 participants