Skip to content

Conversation

@harrynull
Copy link
Contributor

@harrynull harrynull commented Jan 5, 2018

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This pull requests adds a new dependency - FreeType2
It also includes the LICENSE file of FreeType2 (docs/freetype.TXT) (GPL2)

@canihavesomecoffee
Copy link
Member

Could you split the PR up in:

  • Adding the library
  • Making the modifications to the code

This will make the second one smaller, and easier to review.

@harrynull harrynull changed the title [FEATURE] FreeType-based text renderer (-out=spupng with teletext/EIA608) [FEATURE] Add FreeType2 Jan 5, 2018
@harrynull
Copy link
Contributor Author

@canihavesomecoffee Done! I've opened a new PR at #877 .

@cfsmp3 cfsmp3 merged commit 8f0294b into CCExtractor:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants