Skip to content

[FEAT] Add share module in lib_ccxr #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

steel-bucket
Copy link

@steel-bucket steel-bucket commented Jan 5, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}
This PR migrates the sharing service used by the cctranslate service. The first draft was added on 5/1/2025. The new rust Implentation is in /src/rust/lib_ccxr/src/share/.

Changes Made

  • The Rust file containing the main translated logic is in /src/rust/lib_ccxr/src/share/share.rs
  • The Rust file /src/rust/lib_ccxr/src/share/tests.rs contains some preliminary tests.
  • The File /src/rust/src/libccxr_exports/share.rscontains the C bindings, as per doc specification
  • The nanomsg library for rust is being used in this code, just like the nanomsg library is used in the C code. The tests have all ran successfully, although I feel like that the current tests may not be enough to test it out completely.
  • I've also made some changes in the build commands of Linux and Mac to make them build successfully. It does for Linux, as far as I've tested.

@steel-bucket steel-bucket changed the title [FEAT] Add share module in lib_ccxr [FEAT] Add share module in lib_ccxr Jan 5, 2025
@steel-bucket steel-bucket force-pushed the migration-share-module branch from b94da11 to c942503 Compare February 24, 2025 19:28
@steel-bucket steel-bucket force-pushed the migration-share-module branch from c942503 to c302d73 Compare April 16, 2025 08:46
@steel-bucket steel-bucket force-pushed the migration-share-module branch from cc385f0 to a4d04a6 Compare April 20, 2025 07:48
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 888ffa4...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 85/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9e2a594...:

Report Name Tests Passed
Broken 13/13
CEA-708 9/14
DVB 7/7
DVD 0/3
DVR-MS 2/2
General 24/27
Hauppage 1/3
MP4 3/3
NoCC 10/10
Options 79/86
Teletext 7/21
WTV 13/13
XDS 27/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants