close softwareloop#37 Handle NPE when a property node doesn't have child nodes

softwareloop · softwareloop · commit 73f95515c2d4 · 2014-10-08T12:25:08.000+02:00
diff --git a/src/main/amp/web/js/softwareloop/inboxes/Item.js b/src/main/amp/web/js/softwareloop/inboxes/Item.js
@@ -80,7 +80,12 @@ define([
                 var valueNode = browser.getElementsByTagName(propertyString, "cmis", "value");
                 var cmisAttributeValue = null;
                 if (valueNode && valueNode.length > 0) {
-                    cmisAttributeValue = converter(valueNode[0].firstChild.nodeValue);
+                    try {
+                        var nodeValue = valueNode[0].firstChild.nodeValue;
+                        cmisAttributeValue = converter(nodeValue);
+                    } catch (e) {
+                        cmisAttributeValue = null;
+                    }
                 }
                 this.entryAttributes[cmisAttributeName] = cmisAttributeValue;
             }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,12 @@ define([`
`80`	`80`	`var valueNode = browser.getElementsByTagName(propertyString, "cmis", "value");`
`81`	`81`	`var cmisAttributeValue = null;`
`82`	`82`	`if (valueNode && valueNode.length > 0) {`
`83`		`- cmisAttributeValue = converter(valueNode[0].firstChild.nodeValue);`
	`83`	`+ try {`
	`84`	`+ var nodeValue = valueNode[0].firstChild.nodeValue;`
	`85`	`+ cmisAttributeValue = converter(nodeValue);`
	`86`	`+ } catch (e) {`
	`87`	`+ cmisAttributeValue = null;`
	`88`	`+ }`
`84`	`89`	`}`
`85`	`90`	`this.entryAttributes[cmisAttributeName] = cmisAttributeValue;`
`86`	`91`	`}`