Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError: No module named 'urllib3' #443

Open
o-agassizii opened this issue Sep 25, 2023 · 3 comments
Open

ModuleNotFoundError: No module named 'urllib3' #443

o-agassizii opened this issue Sep 25, 2023 · 3 comments

Comments

@o-agassizii
Copy link

When I run this step from the Readme:

rm -f .api.deps .cli.deps && FETCH_APIS=1 make update-json -j8

I get the following error:

[...]
  File "/Users/user/src-dev/github.com/Byron/google-apis-rs/.pyenv-Darwin/lib/python3.11/site-packages/mako/runtime.py", line 943, in _exec_template
    callable_(context, *args, **kwargs)
  File "src/generator/templates/deps.mako", line 24, in render_body
    import urllib3
ModuleNotFoundError: No module named 'urllib3'
make: *** [.cli.deps] Error 1
make: *** Waiting for unfinished jobs....
make: *** [.api.deps] Error 1

This is in spite of the Readme saying:

Make will download all other prerequisites automatically into hidden directories within this repository, which requires it to make some downloads via wget

@o-agassizii
Copy link
Author

As a workaround I did the following:

. ./.pyenv-Darwin/bin/activate
pip install urllib3

And then closed the shell, and opened a new terminal (because I did not want to stay in the venv).

After that it's able to proceed when I run

rm -f .api.deps .cli.deps && FETCH_APIS=1 make update-json -j8

@o-agassizii
Copy link
Author

Imo, this should be considered a bug and the makefiles should be updated so that it also installs the urllib3 dep in the venv on its own

@Byron
Copy link
Owner

Byron commented Sep 25, 2023

Thanks for digging into this, it's much appreciated!

Do you think you can submit a PR with a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants