From 000b85b5da74d8396115e90c23ff952af52fd57c Mon Sep 17 00:00:00 2001 From: Liang Zhang Date: Sun, 18 Dec 2022 22:32:09 +0800 Subject: [PATCH] Refactor BuildInfoCollector (#22956) --- .../metrics/prometheus/collector/BuildInfoCollector.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/agent/plugins/metrics/type/prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/BuildInfoCollector.java b/agent/plugins/metrics/type/prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/BuildInfoCollector.java index f1015b5c8d8f0..9c91327b0fe1c 100644 --- a/agent/plugins/metrics/type/prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/BuildInfoCollector.java +++ b/agent/plugins/metrics/type/prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/BuildInfoCollector.java @@ -20,9 +20,9 @@ import io.prometheus.client.Collector; import io.prometheus.client.GaugeMetricFamily; import lombok.RequiredArgsConstructor; -import lombok.SneakyThrows; import org.apache.shardingsphere.agent.metrics.core.constant.MetricIds; import org.apache.shardingsphere.agent.metrics.prometheus.wrapper.PrometheusWrapperFactory; +import org.apache.shardingsphere.proxy.Bootstrap; import java.util.Arrays; import java.util.Collections; @@ -35,13 +35,10 @@ @RequiredArgsConstructor public final class BuildInfoCollector extends Collector { - private static final String PROXY_BOOTSTRAP_CLASS = "org.apache.shardingsphere.proxy.Bootstrap"; - private static final PrometheusWrapperFactory FACTORY = new PrometheusWrapperFactory(); private final boolean isEnhancedForProxy; - @SneakyThrows(ClassNotFoundException.class) @Override public List collect() { Optional artifactInfo = FACTORY.createGaugeMetricFamily(MetricIds.BUILD_INFO); @@ -50,7 +47,7 @@ public List collect() { } addMetric(artifactInfo.get(), getClass().getPackage()); if (isEnhancedForProxy) { - addMetric(artifactInfo.get(), Class.forName(PROXY_BOOTSTRAP_CLASS).getPackage()); + addMetric(artifactInfo.get(), Bootstrap.class.getPackage()); } return Collections.singletonList(artifactInfo.get()); }