Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More google sheets tests #14548

Merged
merged 2 commits into from
Sep 10, 2024
Merged

More google sheets tests #14548

merged 2 commits into from
Sep 10, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Sep 10, 2024

Description

Made the GoogleSheetsMock a bit more true to the actual API behaviour by "trimming" ValueRanges that come back from the API. I observed that this is how Google Sheets API works in practice, so I've mimicked it here and built more tests on top of it as a result.

@samwho samwho requested a review from a team as a code owner September 10, 2024 16:05
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Sep 10, 2024
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@samwho samwho merged commit 79fc826 into master Sep 10, 2024
11 of 12 checks passed
@samwho samwho deleted the more-google-sheets-tests branch September 10, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants