[BUDI-8579] Create more realistic tests for Google Sheets #14535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
changed the title
samwho
requested review from
adrinr and
mike12345567
and removed request for
a team
adrinr
approved these changes
Sep 10, 2024
mike12345567
approved these changes
Sep 10, 2024
adrinr
approved these changes
Sep 10, 2024
…ase/budibase into budi-8579-issue-with-google-sheets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've completely overhauled how we test our Google Sheets integration. I've created a new utility class called
GoogleSheetsMockwhose job it is to intercept Google Sheets API calls vianockand maintain the state of a mockedSpreadsheetwithin itself. This makes it a crude but useful simple reimplementation of the Google Sheets API that we can write tests against.I'm about 90% sure in the process of doing this, and in #14542, we've fixed the linked bug.
I want to do at least one follow-up PR adding a few more tests, mainly around deletes.
Addresses
Launchcontrol
Fixes several bugs around creating and updating rows in Google Sheets.