Bug 1766262 - move clang-tidy arguments for clangd from cli to spcifi…

…c file. r=marco Differential Revision: https://phabricator.services.mozilla.com/D144577
Brli · Apr 27, 2022 · 84d1b1f · 84d1b1f
1 parent 5f73d94
commit 84d1b1f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -34,6 +34,7 @@ ID
 **/.projectile
 
 # User files that may appear at the root
+/.clang-tidy
 /.mozconfig*
 /mozconfig*
 /configure

diff --git a/.hgignore b/.hgignore
@@ -27,6 +27,7 @@ compile_commands\.json
 \.projectile
 
 # User files that may appear at the root
+^\.clang-tidy
 ^\.mozconfig
 ^mozconfig*
 ^configure$

diff --git a/python/mozbuild/mozbuild/backend/mach_commands.py b/python/mozbuild/mozbuild/backend/mach_commands.py
@@ -249,11 +249,19 @@ def setup_vscode(command_context, vscode_cmd):
             "--pch-storage",
             "memory",
             "--clang-tidy",
-            "--clang-tidy-checks",
-            ",".join(clang_tidy_cfg.checks),
         ],
     }
 
+    clang_tidy = {}
+    clang_tidy["Checks"] = ",".join(clang_tidy_cfg.checks)
+    clang_tidy.update(clang_tidy_cfg.checks_config)
+
+    # Write .clang-tidy yml
+    import yaml
+
+    with open(".clang-tidy", "w") as file:
+        yaml.dump(clang_tidy, file)
+
     # Load the existing .vscode/settings.json file, to check if if needs to
     # be created or updated.
     try: