Bug 1669956 - [devtools] Enable eslint for devtools/client/shared/com…

…ponents/reps. r=jdescottes. Differential Revision: https://phabricator.services.mozilla.com/D93370
Brli · Oct 14, 2020 · 69870cc · 69870cc
1 parent c7f0599
commit 69870cc
Show file tree

Hide file tree

Showing 157 changed files with 1,028 additions and 438 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -66,9 +66,6 @@ devtools/client/debugger/images/
 devtools/client/debugger/test/
 devtools/client/debugger/index.html
 
-# Ignore devtools imported repositories
-devtools/client/shared/components/reps/
-
 # Ignore devtools preferences files
 devtools/client/preferences/
 

diff --git a/devtools/client/shared/components/reps/index.js b/devtools/client/shared/components/reps/index.js
@@ -2,16 +2,23 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { MODE } = require("./reps/constants");
-const { REPS, getRep } = require("./reps/rep");
-const objectInspector = require("./object-inspector/index");
+"use strict";
+
+const {
+  MODE,
+} = require("devtools/client/shared/components/reps/reps/constants");
+const {
+  REPS,
+  getRep,
+} = require("devtools/client/shared/components/reps/reps/rep");
+const objectInspector = require("devtools/client/shared/components/reps/object-inspector/index");
 
 const {
   parseURLEncodedText,
   parseURLParams,
   maybeEscapePropertyName,
   getGripPreviewItems,
-} = require("./reps/rep-utils");
+} = require("devtools/client/shared/components/reps/reps/rep-utils");
 
 module.exports = {
   REPS,

diff --git a/devtools/client/shared/components/reps/object-inspector/actions.js b/devtools/client/shared/components/reps/object-inspector/actions.js
@@ -2,16 +2,16 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { loadItemProperties } = require("./utils/load-properties");
+const { loadItemProperties } = require("devtools/client/shared/components/reps/object-inspector/utils/load-properties");
 const {
   getPathExpression,
   getParentFront,
   getParentGripValue,
   getValue,
   nodeIsBucket,
   getFront,
-} = require("./utils/node");
-const { getLoadedProperties, getWatchpoints } = require("./reducer");
+} = require("devtools/client/shared/components/reps/object-inspector/utils/node");
+const { getLoadedProperties, getWatchpoints } = require("devtools/client/shared/components/reps/object-inspector/reducer");
 
 /**
  * This action is responsible for expanding a given node, which also means that

diff --git a/devtools/client/shared/components/reps/object-inspector/components/ObjectInspector.js b/devtools/client/shared/components/reps/object-inspector/components/ObjectInspector.js
@@ -8,17 +8,17 @@ const {
   createElement,
 } = require("devtools/client/shared/vendor/react");
 const { connect } = require("devtools/client/shared/vendor/react-redux");
-const actions = require("../actions");
+const actions = require("devtools/client/shared/components/reps/object-inspector/actions");
 
-const selectors = require("../reducer");
+const selectors = require("devtools/client/shared/components/reps/object-inspector/reducer");
 
 import Components from "devtools-components";
 const Tree = createFactory(Components.Tree);
-require("./ObjectInspector.css");
+require("devtools/client/shared/components/reps/object-inspector/components/ObjectInspector.css");
 
-const ObjectInspectorItem = createFactory(require("./ObjectInspectorItem"));
+const ObjectInspectorItem = createFactory(require("devtools/client/shared/components/reps/object-inspector/components/ObjectInspectorItem"));
 
-const Utils = require("../utils/index");
+const Utils = require("devtools/client/shared/components/reps/object-inspector/utils/index");
 const { renderRep, shouldRenderRootsInReps } = Utils;
 const {
   getChildrenWithEvaluations,

diff --git a/devtools/client/shared/components/reps/object-inspector/components/ObjectInspectorItem.js b/devtools/client/shared/components/reps/object-inspector/components/ObjectInspectorItem.js
@@ -8,9 +8,11 @@ const dom = require("devtools/client/shared/vendor/react-dom-factories");
 const Services = require("Services");
 const isMacOS = Services.appinfo.OS === "Darwin";
 
-const { MODE } = require("../../reps/constants");
+const {
+  MODE,
+} = require("devtools/client/shared/components/reps/reps/constants");
 
-const Utils = require("../utils/index");
+const Utils = require("devtools/client/shared/components/reps/object-inspector/utils/index");
 
 const {
   getValue,

diff --git a/devtools/client/shared/components/reps/object-inspector/index.js b/devtools/client/shared/components/reps/object-inspector/index.js
@@ -2,9 +2,9 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const ObjectInspector = require("./components/ObjectInspector");
-const utils = require("./utils/index");
-const reducer = require("./reducer");
-const actions = require("./actions");
+const ObjectInspector = require("devtools/client/shared/components/reps/object-inspector/components/ObjectInspector");
+const utils = require("devtools/client/shared/components/reps/object-inspector/utils/index");
+const reducer = require("devtools/client/shared/components/reps/object-inspector/reducer");
+const actions = require("devtools/client/shared/components/reps/object-inspector/actions");
 
 module.exports = { ObjectInspector, utils, actions, reducer };
diff --git a/devtools/client/shared/components/reps/object-inspector/tests/.eslintrc.js b/devtools/client/shared/components/reps/object-inspector/tests/.eslintrc.js
@@ -0,0 +1,10 @@
+/* Any copyright is dedicated to the Public Domain.
+   http://creativecommons.org/publicdomain/zero/1.0/ */
+
+"use strict";
+
+module.exports = {
+  env: {
+    jest: true,
+  },
+};
diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/basic.js b/devtools/client/shared/components/reps/object-inspector/tests/component/basic.js
@@ -2,18 +2,18 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { mountObjectInspector } = require("../test-utils");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 const { mount } = require("enzyme");
-const { createNode, NODE_TYPES } = require("../../utils/node");
+const { createNode, NODE_TYPES } = require("devtools/client/shared/components/reps/object-inspector/utils/node");
 const repsPath = "../../../reps";
 const { MODE } = require(`${repsPath}/constants`);
 const { Rep } = require(`${repsPath}/rep`);
 const {
   formatObjectInspector,
   waitForDispatch,
   waitForLoadedProperties,
-} = require("../test-utils");
-const ObjectFront = require("../__mocks__/object-front");
+} = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 const gripRepStubs = require(`${repsPath}/stubs/grip`);
 
 function generateDefaults(overrides) {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/classnames.js b/devtools/client/shared/components/reps/object-inspector/tests/component/classnames.js
@@ -2,8 +2,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const ObjectFront = require("../__mocks__/object-front");
-const { mountObjectInspector } = require("../test-utils");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
 function generateDefaults(overrides) {
   return {

diff --git a/...lient/shared/components/reps/object-inspector/tests/component/create-long-string-front.js b/...lient/shared/components/reps/object-inspector/tests/component/create-long-string-front.js
@@ -4,9 +4,9 @@
 
 /* global jest */
 
-const { mountObjectInspector } = require("../test-utils");
-const ObjectFront = require("../__mocks__/object-front");
-const { LongStringFront } = require("../__mocks__/string-front");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
+const { LongStringFront } = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/string-front");
 
 const repsPath = "../../../reps";
 const longStringStubs = require(`${repsPath}/stubs/long-string`);

diff --git a/...ls/client/shared/components/reps/object-inspector/tests/component/create-object-client.js b/...ls/client/shared/components/reps/object-inspector/tests/component/create-object-client.js
@@ -4,14 +4,14 @@
 
 /* global jest */
 
-const { mountObjectInspector } = require("../test-utils");
-const ObjectFront = require("../__mocks__/object-front");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 
 const {
   createNode,
   makeNodesForEntries,
   makeNumericalBuckets,
-} = require("../../utils/node");
+} = require("devtools/client/shared/components/reps/object-inspector/utils/node");
 
 const repsPath = "../../../reps";
 const gripRepStubs = require(`${repsPath}/stubs/grip`);

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/entries.js b/devtools/client/shared/components/reps/object-inspector/tests/component/entries.js
@@ -4,16 +4,16 @@
 
 /* global jest */
 
-const { mountObjectInspector } = require("../test-utils");
-const { MODE } = require("../../../reps/constants");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const { MODE } = require("devtools/client/shared/components/reps/reps/constants");
 const {
   formatObjectInspector,
   waitForDispatch,
   waitForLoadedProperties,
-} = require("../test-utils");
-const gripMapRepStubs = require("../../../reps/stubs/grip-map");
-const mapStubs = require("../../stubs/map");
-const ObjectFront = require("../__mocks__/object-front");
+} = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const gripMapRepStubs = require("devtools/client/shared/components/reps/reps/stubs/grip-map");
+const mapStubs = require("devtools/client/shared/components/reps/object-inspector/stubs/map");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 
 function generateDefaults(overrides) {
   return {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/events.js b/devtools/client/shared/components/reps/object-inspector/tests/component/events.js
@@ -3,10 +3,10 @@
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
 /* global jest */
-const { mountObjectInspector } = require("../test-utils");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
-const gripRepStubs = require("../../../reps/stubs/grip");
-const ObjectFront = require("../__mocks__/object-front");
+const gripRepStubs = require("devtools/client/shared/components/reps/reps/stubs/grip");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 
 function generateDefaults(overrides) {
   return {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/expand.js b/devtools/client/shared/components/reps/object-inspector/tests/component/expand.js
@@ -1,22 +1,22 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
-const { mountObjectInspector } = require("../test-utils");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
 const repsPath = "../../../reps";
 const { MODE } = require(`${repsPath}/constants`);
-const ObjectFront = require("../__mocks__/object-front");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 const gripRepStubs = require(`${repsPath}/stubs/grip`);
-const gripPropertiesStubs = require("../../stubs/grip");
+const gripPropertiesStubs = require("devtools/client/shared/components/reps/object-inspector/stubs/grip");
 const {
   formatObjectInspector,
   storeHasExactExpandedPaths,
   storeHasExpandedPath,
   storeHasLoadedProperty,
   waitForDispatch,
-} = require("../test-utils");
-const { createNode, NODE_TYPES } = require("../../utils/node");
-const { getExpandedPaths } = require("../../reducer");
+} = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const { createNode, NODE_TYPES } = require("devtools/client/shared/components/reps/object-inspector/utils/node");
+const { getExpandedPaths } = require("devtools/client/shared/components/reps/object-inspector/reducer");
 
 const protoStub = {
   prototype: {
@@ -48,7 +48,7 @@ function generateDefaults(overrides) {
     ...overrides,
   };
 }
-const { LongStringFront } = require("../__mocks__/string-front");
+const { LongStringFront } = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/string-front");
 
 function getClient(overrides = {}) {
   return {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/function.js b/devtools/client/shared/components/reps/object-inspector/tests/component/function.js
@@ -2,12 +2,12 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { mountObjectInspector } = require("../test-utils");
-const { MODE } = require("../../../reps/constants");
-const { createNode } = require("../../utils/node");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const { MODE } = require("devtools/client/shared/components/reps/reps/constants");
+const { createNode } = require("devtools/client/shared/components/reps/object-inspector/utils/node");
 
-const functionStubs = require("../../../reps/stubs/function");
-const ObjectFront = require("../__mocks__/object-front");
+const functionStubs = require("devtools/client/shared/components/reps/reps/stubs/function");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 
 function generateDefaults(overrides) {
   return {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/getter-setter.js b/devtools/client/shared/components/reps/object-inspector/tests/component/getter-setter.js
@@ -2,16 +2,16 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { MODE } = require("../../../reps/constants");
+const { MODE } = require("devtools/client/shared/components/reps/reps/constants");
 const {
   formatObjectInspector,
   waitForLoadedProperties,
   mountObjectInspector,
-} = require("../test-utils");
+} = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
-const { makeNodesForProperties } = require("../../utils/node");
-const accessorStubs = require("../../../reps/stubs/accessor");
-const ObjectFront = require("../__mocks__/object-front");
+const { makeNodesForProperties } = require("devtools/client/shared/components/reps/object-inspector/utils/node");
+const accessorStubs = require("devtools/client/shared/components/reps/reps/stubs/accessor");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 
 function generateDefaults(overrides) {
   return {

diff --git a/...ols/client/shared/components/reps/object-inspector/tests/component/keyboard-navigation.js b/...ols/client/shared/components/reps/object-inspector/tests/component/keyboard-navigation.js
@@ -2,12 +2,12 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { mountObjectInspector } = require("../test-utils");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 const repsPath = "../../../reps";
 const { MODE } = require(`${repsPath}/constants`);
 
-const { formatObjectInspector, waitForDispatch } = require("../test-utils");
-const ObjectFront = require("../__mocks__/object-front");
+const { formatObjectInspector, waitForDispatch } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 const gripRepStubs = require(`${repsPath}/stubs/grip`);
 
 function generateDefaults(overrides) {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/properties.js b/devtools/client/shared/components/reps/object-inspector/tests/component/properties.js
@@ -4,11 +4,11 @@
 
 /* global jest */
 
-const { mountObjectInspector } = require("../test-utils");
-const gripRepStubs = require("../../../reps/stubs/grip");
-const ObjectFront = require("../__mocks__/object-front");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const gripRepStubs = require("devtools/client/shared/components/reps/reps/stubs/grip");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 
-const { formatObjectInspector } = require("../test-utils");
+const { formatObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
 function generateDefaults(overrides) {
   return {

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/proxy.js b/devtools/client/shared/components/reps/object-inspector/tests/component/proxy.js
@@ -3,15 +3,15 @@
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
 /* global jest */
-const { mountObjectInspector } = require("../test-utils");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
-const { MODE } = require("../../../reps/constants");
-const gripStubs = require("../../../reps/stubs/grip");
+const { MODE } = require("devtools/client/shared/components/reps/reps/constants");
+const gripStubs = require("devtools/client/shared/components/reps/reps/stubs/grip");
 const stub = gripStubs.get("testProxy");
 const proxySlots = gripStubs.get("testProxySlots");
-const { formatObjectInspector } = require("../test-utils");
+const { formatObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
-const ObjectFront = require("../__mocks__/object-front");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 function generateDefaults(overrides) {
   return {
     roots: [

diff --git a/...ools/client/shared/components/reps/object-inspector/tests/component/should-item-update.js b/...ools/client/shared/components/reps/object-inspector/tests/component/should-item-update.js
@@ -4,9 +4,9 @@
 
 /* global jest */
 
-const { mountObjectInspector } = require("../test-utils");
-const ObjectFront = require("../__mocks__/object-front");
-const { LongStringFront } = require("../__mocks__/string-front");
+const { mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
+const { LongStringFront } = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/string-front");
 
 const repsPath = "../../../reps";
 const longStringStubs = require(`${repsPath}/stubs/long-string`);

diff --git a/devtools/client/shared/components/reps/object-inspector/tests/component/window.js b/devtools/client/shared/components/reps/object-inspector/tests/component/window.js
@@ -2,11 +2,11 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { createNode } = require("../../utils/node");
-const { waitForDispatch, mountObjectInspector } = require("../test-utils");
+const { createNode } = require("devtools/client/shared/components/reps/object-inspector/utils/node");
+const { waitForDispatch, mountObjectInspector } = require("devtools/client/shared/components/reps/object-inspector/tests/test-utils");
 
-const gripWindowStubs = require("../../../reps/stubs/window");
-const ObjectFront = require("../__mocks__/object-front");
+const gripWindowStubs = require("devtools/client/shared/components/reps/reps/stubs/window");
+const ObjectFront = require("devtools/client/shared/components/reps/object-inspector/tests/__mocks__/object-front");
 const windowNode = createNode({
   name: "window",
   contents: { value: gripWindowStubs.get("Window") },