Bug 1504835 - Remove remaining references to web replay graphics over…

…lay, r=lsmyth.

devtools/server/actors/replay/graphics.js

@@ -25,8 +25,7 @@ Cu.evalInSandbox(
 );
 
 // Windows in the middleman process are initially set up as about:blank pages.
-// This method fills them in with a canvas filling the tab, and an overlay that
-// can be displayed over that canvas.
+// This method fills them in with a canvas filling the tab.
 function setupContents(window) {
   // The middlemanCanvas element fills the tab's contents.
   const canvas = window.middlemanCanvas = window.document.createElement("canvas");
@@ -91,13 +90,7 @@ function UpdateCanvas(buffer, width, height, hadFailure) {
   }
 }
 
-// Entry point for when we need to update the overlay's contents or visibility.
-// eslint-disable-next-line no-unused-vars
-function UpdateOverlay() {
-}
-
 // eslint-disable-next-line no-unused-vars
 var EXPORTED_SYMBOLS = [
   "UpdateCanvas",
-  "UpdateOverlay",
 ];

toolkit/recordreplay/ipc/ParentGraphics.cpp

@@ -201,23 +201,6 @@ UpdateGraphicsInUIProcess(const PaintMessage* aMsg)
   }
 }
 
-void
-UpdateGraphicsOverlay()
-{
-  if (!gLastPaintWidth || !gLastPaintHeight) {
-    return;
-  }
-
-  AutoSafeJSContext cx;
-  JSAutoRealm ar(cx, *gGraphicsSandbox);
-
-  RootedValue rval(cx);
-  if (!JS_CallFunctionName(cx, *gGraphicsSandbox, "UpdateOverlay",
-                           JS::HandleValueArray::empty(), &rval)) {
-    MOZ_CRASH("UpdateGraphicsOverlay");
-  }
-}
-
 static void
 MaybeTriggerExplicitPaint()
 {

toolkit/recordreplay/ipc/ParentIPC.cpp

@@ -611,12 +611,6 @@ SwitchActiveChild(ChildProcessInfo* aChild, bool aRecoverPosition = true)
     oldActiveChild->RecoverToCheckpoint(oldActiveChild->MostRecentSavedCheckpoint());
     oldActiveChild->SetRole(MakeUnique<ChildRoleStandby>());
   }
-
-  // The graphics overlay is affected when we switch between recording and
-  // replaying children.
-  if (aChild->IsRecording() != oldActiveChild->IsRecording()) {
-    UpdateGraphicsOverlay();
-  }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -1187,10 +1181,6 @@ RecvHitCheckpoint(const HitCheckpointMessage& aMsg)
   UpdateCheckpointTimes(aMsg);
   MaybeUpdateGraphicsAtCheckpoint(aMsg.mCheckpointId);
 
-  if (!gActiveChild->IsRecording()) {
-    UpdateGraphicsOverlay();
-  }
-
   // Resume either forwards or backwards. Break the resume off into a separate
   // runnable, to avoid starving any code already on the stack and waiting for
   // the process to pause. Immediately resume if the main thread is blocked.

toolkit/recordreplay/ipc/ParentInternal.h

@@ -94,9 +94,6 @@ void SendGraphicsMemoryToChild();
 // an unhandled recording divergence.
 void UpdateGraphicsInUIProcess(const PaintMessage* aMsg);
 
-// Update the overlay shown over the tab's graphics.
-void UpdateGraphicsOverlay();
-
 // If necessary, update graphics after the active child sends a paint message
 // or reaches a checkpoint.
 void MaybeUpdateGraphicsAtPaint(const PaintMessage& aMsg);