Skip to content

Commit

Permalink
Bug 1263325 - Unbreak build with libc++ and config/gcc_hidden.h after…
Browse files Browse the repository at this point in the history
… bug 1239083. r=glandium

MozReview-Commit-ID: 4y4j6o7V54D
  • Loading branch information
jbeich committed Apr 11, 2016
1 parent c25ea60 commit 5c2af75
Show file tree
Hide file tree
Showing 5 changed files with 69 additions and 26 deletions.
66 changes: 66 additions & 0 deletions intl/icu-patches/bug-1228227-bug-1263325-libc++-gcc_hidden.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
Limit libstdc++ workaround to not upset libc++ with pragma visibility.

https://ssl.icu-project.org/trac/ticket/12023

diff --git a/intl/icu/source/common/unicode/std_string.h b/intl/icu/source/common/unicode/std_string.h
--- a/intl/icu/source/common/unicode/std_string.h
+++ b/intl/icu/source/common/unicode/std_string.h
@@ -22,16 +22,16 @@
* \brief C++ API: Central ICU header for including the C++ standard <string>
* header and for related definitions.
*/

#include "unicode/utypes.h"

#if U_HAVE_STD_STRING

-#if !defined(_MSC_VER)
+#if defined(__GLIBCXX__)
namespace std { class type_info; } // WORKAROUND: http://llvm.org/bugs/show_bug.cgi?id=13364
#endif
#include <string>

#endif // U_HAVE_STD_STRING

#endif // __STD_STRING_H__
diff --git a/intl/icu/source/common/utypeinfo.h b/intl/icu/source/common/utypeinfo.h
--- a/intl/icu/source/common/utypeinfo.h
+++ b/intl/icu/source/common/utypeinfo.h
@@ -17,14 +17,14 @@
// Whenever 'typeid' is used, this header has to be included
// instead of <typeinfo>.
// Visual Stuido 10 emits warning 4275 with this change. If you compile
// with exception disabled, you have to suppress warning 4275.
#if defined(_MSC_VER) && _HAS_EXCEPTIONS == 0
#include <exception>
using std::exception;
#endif
-#if !defined(_MSC_VER)
+#if defined(__GLIBCXX__)
namespace std { class type_info; } // WORKAROUND: http://llvm.org/bugs/show_bug.cgi?id=13364
#endif
#include <typeinfo> // for 'typeid' to work

#endif
diff --git a/intl/icu/source/io/unicode/ustream.h b/intl/icu/source/io/unicode/ustream.h
--- a/intl/icu/source/io/unicode/ustream.h
+++ b/intl/icu/source/io/unicode/ustream.h
@@ -23,17 +23,17 @@
* \file
* \brief C++ API: Unicode iostream like API
*
* At this time, this API is very limited. It contains
* operator<< and operator>> for UnicodeString manipulation with the
* C++ I/O stream API.
*/

-#if !defined(_MSC_VER)
+#if defined(__GLIBCXX__)
namespace std { class type_info; } // WORKAROUND: http://llvm.org/bugs/show_bug.cgi?id=13364
#endif

#if U_IOSTREAM_SOURCE >= 199711
#if (__GNUC__ == 2)
#include <iostream>
#else
#include <istream>
23 changes: 0 additions & 23 deletions intl/icu-patches/bug-1228227-libc++-gcc_hidden.diff

This file was deleted.

2 changes: 1 addition & 1 deletion intl/icu/source/common/utypeinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include <exception>
using std::exception;
#endif
#if !defined(_MSC_VER)
#if defined(__GLIBCXX__)
namespace std { class type_info; } // WORKAROUND: http://llvm.org/bugs/show_bug.cgi?id=13364
#endif
#include <typeinfo> // for 'typeid' to work
Expand Down
2 changes: 1 addition & 1 deletion intl/icu/source/io/unicode/ustream.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* C++ I/O stream API.
*/

#if !defined(_MSC_VER)
#if defined(__GLIBCXX__)
namespace std { class type_info; } // WORKAROUND: http://llvm.org/bugs/show_bug.cgi?id=13364
#endif

Expand Down
2 changes: 1 addition & 1 deletion intl/update-icu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ for patch in \
bug-1172609-timezone-recreateDefault.diff \
bug-1198952-workaround-make-3.82-bug.diff \
icu-release-56-1-flagparser-fix.patch \
bug-1228227-libc++-gcc_hidden.diff \
bug-1228227-bug-1263325-libc++-gcc_hidden.diff \
; do
echo "Applying local patch $patch"
patch -d ${icu_dir}/../../ -p1 --no-backup-if-mismatch < ${icu_dir}/../icu-patches/$patch
Expand Down

0 comments on commit 5c2af75

Please sign in to comment.