Skip to content

Commit

Permalink
Bug 1248534 (part 1) - Remove XPT encoding support. r=khuey.
Browse files Browse the repository at this point in the history
Currently XPT can both encode and decode, but encoding has been handled by
Python code since bug 643817, so the encoding support can be removed. This
results in many simplifications. Some notable changes:

- All the XPTHashTable code (including XPTDatapool::offset_map) is no longer
  necessary.

- PrimitiveTest.cpp and SimpleTypeLib.cpp both don't make much sense without
  encoding support, so I removed them.

- A lot of the version code was already unused, e.g. XPT_VERSION_*,
  XPT_TYPELIB_VERSIONS_STRUCT, XPT_TYPELIB_VERSIONS.
  XPT_MAJOR_INCOMPATIBLE_VERSION is the only thing actually used in version
  checks.

- The patch also removes some code that was dead even before encoding removal,
  such as XPT_ParseVersionString().
  • Loading branch information
nnethercote committed Feb 16, 2016
1 parent 76a9d3d commit 502a34f
Show file tree
Hide file tree
Showing 9 changed files with 108 additions and 1,424 deletions.
1 change: 0 additions & 1 deletion xpcom/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ if CONFIG['OS_ARCH'] == 'WINNT' and CONFIG['MOZ_DEBUG']:

TEST_DIRS += [
'tests',
'typelib/xpt/tests',
]

# Can't build internal xptcall tests that use symbols which are not exported.
Expand Down
2 changes: 1 addition & 1 deletion xpcom/reflect/xptinfo/xptiInterfaceInfoManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ XPTInterfaceInfoManager::InitMemoryReporter()
void
XPTInterfaceInfoManager::RegisterBuffer(char *buf, uint32_t length)
{
XPTState *state = XPT_NewXDRState(XPT_DECODE, buf, length);
XPTState *state = XPT_NewXDRState(buf, length);
if (!state)
return;

Expand Down
127 changes: 0 additions & 127 deletions xpcom/typelib/xpt/tests/PrimitiveTest.cpp

This file was deleted.

152 changes: 0 additions & 152 deletions xpcom/typelib/xpt/tests/SimpleTypeLib.cpp

This file was deleted.

14 changes: 0 additions & 14 deletions xpcom/typelib/xpt/tests/moz.build

This file was deleted.

Loading

0 comments on commit 502a34f

Please sign in to comment.