From 4b39b7c0ac6038c00b36cdadd5b9d445c4dc930a Mon Sep 17 00:00:00 2001 From: Trevor Saunders Date: Thu, 7 May 2015 10:26:01 -0400 Subject: [PATCH] bug 1162543 - IDs not mapping to accessibles shouldn't cause ipc calls to fail r=davidb This is expected to happen when a accessible in the child process is shutdown, but the parent calls a method with its ID before learning it has been shut down. --- accessible/ipc/DocAccessibleChild.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accessible/ipc/DocAccessibleChild.cpp b/accessible/ipc/DocAccessibleChild.cpp index 6af4e8f3c14d1..10d21d5442fa8 100644 --- a/accessible/ipc/DocAccessibleChild.cpp +++ b/accessible/ipc/DocAccessibleChild.cpp @@ -224,7 +224,7 @@ DocAccessibleChild::RecvRelationByType(const uint64_t& aID, { Accessible* acc = mDoc->GetAccessibleByUniqueID((void*)aID); if (!acc) - return false; + return true; auto type = static_cast(aType); Relation rel = acc->RelationByType(type); @@ -256,8 +256,8 @@ DocAccessibleChild::RecvRelations(const uint64_t& aID, nsTArray* aRelations) { Accessible* acc = mDoc->GetAccessibleByUniqueID((void*)aID); - if (!aID) - return false; + if (!acc) + return true; #define RELATIONTYPE(gecko, s, a, m, i) AddRelation(acc, RelationType::gecko, aRelations);