Skip to content

Commit

Permalink
Bug 1080968 - Don't use constexpr on clang-cl when emulating MSVC 2013
Browse files Browse the repository at this point in the history
constexpr-ness of things can change the ABI requirements, and MSVC 2013
doesn't support constexpr, so choosing it for clang-cl when emulating
MSVC 2013 will cause ABI incomap issues between object files compiled
with the two compilers.

This reverts part of the commit for the original bug.
  • Loading branch information
ehsan committed Jan 28, 2016
1 parent 76d1cc7 commit 2274aec
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions mfbt/Attributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@
# define MOZ_HAVE_EXPLICIT_CONVERSION
# endif
# ifdef __clang__
/* clang-cl probably supports constexpr and explicit conversions. */
# if __has_extension(cxx_constexpr)
# define MOZ_HAVE_CXX11_CONSTEXPR
# endif
/* clang-cl probably supports explicit conversions. */
# if __has_extension(cxx_explicit_conversions)
# define MOZ_HAVE_EXPLICIT_CONVERSION
# endif
Expand Down

0 comments on commit 2274aec

Please sign in to comment.