chore: refactor bnb labels hiding

- when showing only selected, the width is the same so the overflow also occurs...

Author: BrightDV

lib/helpers/bottom_navigation_bar.dart

@@ -100,6 +100,8 @@ class _MainBottomNavigationBarState extends State<MainBottomNavigationBar> {
     if (_selectedIndex == 0) {
       actions = UIProvider().getNewsAppBarActions(context);
     }
+    bool disableBottomNavigationBarLabels = Hive.box('settings')
+        .get('disableBottomNavigationBarLabels', defaultValue: false) as bool;
 
     return Scaffold(
       appBar: AppBar(
@@ -120,6 +122,9 @@ class _MainBottomNavigationBarState extends State<MainBottomNavigationBar> {
         elevation: 10.0,
         destinations: UIProvider().getBottomNavigationBarButtons(context),
         onDestinationSelected: _onItemTapped,
+        labelBehavior: disableBottomNavigationBarLabels
+            ? NavigationDestinationLabelBehavior.alwaysHide
+            : NavigationDestinationLabelBehavior.alwaysShow,
       ),
       body: screens.elementAt(_selectedIndex),
     );

lib/providers/general/ui.dart

@@ -212,8 +212,6 @@ class UIProvider {
   ) {
     String championship = Hive.box('settings')
         .get('championship', defaultValue: 'Formula 1') as String;
-    bool disableBottomNavigationBarLabels = Hive.box('settings')
-        .get('disableBottomNavigationBarLabels', defaultValue: false) as bool;
     if (championship == 'Formula 1' || championship == 'Formula E') {
       return [
         NavigationDestination(
@@ -223,9 +221,7 @@ class UIProvider {
           selectedIcon: const Icon(
             Icons.feed,
           ),
-          label: !disableBottomNavigationBarLabels
-              ? AppLocalizations.of(context)!.news
-              : "",
+          label: AppLocalizations.of(context)!.news,
         ),
         NavigationDestination(
           icon: const Icon(
@@ -234,9 +230,7 @@ class UIProvider {
           selectedIcon: const Icon(
             Icons.play_circle,
           ),
-          label: !disableBottomNavigationBarLabels
-              ? AppLocalizations.of(context)!.videos
-              : "",
+          label: AppLocalizations.of(context)!.videos,
         ),
         NavigationDestination(
           icon: const Icon(
@@ -245,9 +239,7 @@ class UIProvider {
           selectedIcon: const Icon(
             Icons.emoji_events,
           ),
-          label: !disableBottomNavigationBarLabels
-              ? AppLocalizations.of(context)!.standings
-              : "",
+          label: AppLocalizations.of(context)!.standings,
         ),
         NavigationDestination(
           icon: const Icon(
@@ -256,9 +248,7 @@ class UIProvider {
           selectedIcon: const Icon(
             Icons.calendar_today,
           ),
-          label: !disableBottomNavigationBarLabels
-              ? AppLocalizations.of(context)!.schedule
-              : "",
+          label: AppLocalizations.of(context)!.schedule,
         ),
       ];
     } else if (championship == 'Formula 2' ||