Skip to content

Commit b0e2fd0

Browse files
estrada9166BridgeAR
authored andcommitted
doc: add new documentation lint rule
Add 80 characters limit to docs. Change docs to fit 80 characters per row. PR-URL: nodejs#18726 Fixes: nodejs#18703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent edb0197 commit b0e2fd0

28 files changed

+115
-99
lines changed

BUILDING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Support is divided into three tiers:
3434
### Supported platforms
3535

3636
The community does not build or test against end-of-life distributions (EoL).
37-
Thus we do not recommend that you use Node on end-of-life or unsupported
37+
Thus we do not recommend that you use Node on end-of-life or unsupported
3838
platforms in production.
3939

4040
| System | Support type | Version | Architectures | Notes |
@@ -108,10 +108,10 @@ installed, you can find them under the menu `Xcode -> Open Developer Tool ->
108108
More Developer Tools...`. This step will install `clang`, `clang++`, and
109109
`make`.
110110
* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh)
111-
to avoid popups asking to accept incoming network connections when running
111+
to avoid popups asking to accept incoming network connections when running
112112
tests:
113113

114-
If the path to your build directory contains a space, the build will likely
114+
If the path to your build directory contains a space, the build will likely
115115
fail.
116116

117117
```console
@@ -244,7 +244,7 @@ Prerequisites:
244244
* **Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/)
245245
and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension).
246246

247-
If the path to your build directory contains a space or a non-ASCII character,
247+
If the path to your build directory contains a space or a non-ASCII character,
248248
the build will likely fail.
249249

250250
```console

COLLABORATOR_GUIDE.md

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -208,19 +208,24 @@ confirm that the changes are not resulting in an unreliable test.
208208
#### Useful CI Jobs
209209

210210
* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
211-
is the standard CI run we do to check Pull Requests. It triggers
212-
`node-test-commit`, which runs the `build-ci` and `test-ci` targets on all
211+
is the standard CI run we do to check Pull Requests. It triggers
212+
`node-test-commit`, which runs the `build-ci` and `test-ci` targets on all
213213
supported platforms.
214214

215+
* [`node-test-linter`](https://ci.nodejs.org/job/node-test-linter/)
216+
only runs the linter targets, which is useful for changes that only affect
217+
comments or documentation.
218+
215219
* [`node-test-pull-request-lite`](https://ci.nodejs.org/job/node-test-pull-request-lite/)
216220
only runs the linter job, as well as the tests on LinuxONE, which is very fast.
217221
This is useful for changes that only affect comments or documentation.
218222

219223
* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
220-
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run `npm
221-
install && npm test` on a large selection of common modules. This is useful to
222-
check whether a change will cause breakage in the ecosystem. To test Node.js
223-
ABI changes you can run [`citgm-abi-smoker`](https://ci.nodejs.org/job/citgm-abi-smoker/).
224+
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run
225+
`npm install && npm test` on a large selection of common modules. This is useful
226+
to check whether a change will cause breakage in the ecosystem. To test Node.js
227+
ABI changes you can run
228+
[`citgm-abi-smoker`](https://ci.nodejs.org/job/citgm-abi-smoker/).
224229

225230
* [`node-stress-single-test`](https://ci.nodejs.org/job/node-stress-single-test/)
226231
is designed to allow one to run a group of tests over and over on a specific
@@ -561,7 +566,7 @@ Apply external patches:
561566
$ curl -L https://github.com/nodejs/node/pull/xxx.patch | git am --whitespace=fix
562567
```
563568

564-
If the merge fails even though recent CI runs were successful, then a 3-way
569+
If the merge fails even though recent CI runs were successful, then a 3-way
565570
merge may be required. In this case try:
566571

567572
```text
@@ -570,8 +575,8 @@ $ curl -L https://github.com/nodejs/node/pull/xxx.patch | git am -3 --whitespace
570575
```
571576
If the 3-way merge succeeds you can proceed, but make sure to check the changes
572577
against the original PR carefully and build/test on at least one platform
573-
before landing. If the 3-way merge fails, then it is most likely that a
574-
conflicting PR has landed since the CI run and you will have to ask the author
578+
before landing. If the 3-way merge fails, then it is most likely that a
579+
conflicting PR has landed since the CI run and you will have to ask the author
575580
to rebase.
576581

577582
Check and re-review the changes:

GOVERNANCE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ repository, with a summary of the nominee's contributions, for example:
160160
Node.js organization
161161
* Can be shown using the links
162162
`https://github.com/search?q=author%3A${GITHUB_ID}++org%3Anodejs&type=Issues`
163-
and
163+
and
164164
`https://github.com/search?q=commenter%3A${GITHUB_ID}++org%3Anodejs&type=Issues`
165165
* Other participation in the wider Node.js community
166166

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<p align="center">
22
<a href="https://nodejs.org/">
3-
<img
4-
alt="Node.js"
5-
src="https://nodejs.org/static/images/logo-light.svg"
3+
<img
4+
alt="Node.js"
5+
src="https://nodejs.org/static/images/logo-light.svg"
66
width="400"
77
/>
88
</a>

doc/api/cluster.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ changes:
269269

270270
* Returns: {cluster.Worker} A reference to `worker`.
271271

272-
In a worker, this function will close all servers, wait for the `'close'` event
272+
In a worker, this function will close all servers, wait for the `'close'` event
273273
on those servers, and then disconnect the IPC channel.
274274

275275
In the master, an internal message is sent to the worker causing it to call
@@ -280,7 +280,7 @@ Causes `.exitedAfterDisconnect` to be set.
280280
Note that after a server is closed, it will no longer accept new connections,
281281
but connections may be accepted by any other listening worker. Existing
282282
connections will be allowed to close as usual. When no more connections exist,
283-
see [`server.close()`][], the IPC channel to the worker will close allowing it
283+
see [`server.close()`][], the IPC channel to the worker will close allowing it
284284
to die gracefully.
285285

286286
The above applies *only* to server connections, client connections are not
@@ -639,7 +639,7 @@ Calls `.disconnect()` on each worker in `cluster.workers`.
639639
When they are disconnected all internal handles will be closed, allowing the
640640
master process to die gracefully if no other event is waiting.
641641

642-
The method takes an optional callback argument which will be called when
642+
The method takes an optional callback argument which will be called when
643643
finished.
644644

645645
This can only be called from the master process.

doc/api/console.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ added: v8.0.0
441441
* `label` {string} **Default:** `'default'`
442442

443443
This method does not display anything unless used in the inspector. The
444-
`console.markTimeline()` method is the deprecated form of
444+
`console.markTimeline()` method is the deprecated form of
445445
[`console.timeStamp()`][].
446446

447447
### console.profile([label])
@@ -508,7 +508,7 @@ added: v8.0.0
508508
* `label` {string} **Default:** `'default'`
509509

510510
This method does not display anything unless used in the inspector. The
511-
`console.timelineEnd()` method is the deprecated form of
511+
`console.timelineEnd()` method is the deprecated form of
512512
[`console.timeEnd()`][].
513513

514514
[`console.error()`]: #console_console_error_data_args

doc/api/debugger.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
Node.js includes an out-of-process debugging utility accessible via a
1010
[V8 Inspector][] and built-in debugging client. To use it, start Node.js
11-
with the `inspect` argument followed by the path to the script to debug; a
11+
with the `inspect` argument followed by the path to the script to debug; a
1212
prompt will be displayed indicating successful launch of the debugger:
1313

1414
```txt
@@ -173,7 +173,7 @@ breakpoint)
173173
### V8 Inspector Integration for Node.js
174174

175175
V8 Inspector integration allows attaching Chrome DevTools to Node.js
176-
instances for debugging and profiling. It uses the
176+
instances for debugging and profiling. It uses the
177177
[Chrome Debugging Protocol][].
178178

179179
V8 Inspector can be enabled by passing the `--inspect` flag when starting a

doc/api/deprecations.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -699,8 +699,8 @@ Type: Runtime
699699
700700
`Module._debug()` has been deprecated.
701701
702-
The `Module._debug()` function was never documented as an officially
703-
supported API.
702+
The `Module._debug()` function was never documented as an officially supported
703+
API.
704704
705705
<a id="DEP0078"></a>
706706
### DEP0078: REPLServer.turnOffEditorMode()

doc/api/dgram.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ added: v8.6.0
394394

395395
*Note: All references to scope in this section are referring to
396396
[IPv6 Zone Indices][], which are defined by [RFC 4007][]. In string form, an IP
397-
with a scope index is written as `'IP%scope'` where scope is an interface name
397+
with a scope index is written as `'IP%scope'` where scope is an interface name
398398
or interface number.*
399399

400400
Sets the default outgoing multicast interface of the socket to a chosen

doc/api/dns.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ changes:
143143
- `verbatim` {boolean} When `true`, the callback receives IPv4 and IPv6
144144
addresses in the order the DNS resolver returned them. When `false`,
145145
IPv4 addresses are placed before IPv6 addresses.
146-
**Default:** currently `false` (addresses are reordered) but this is
146+
**Default:** currently `false` (addresses are reordered) but this is
147147
expected to change in the not too distant future.
148148
New code should use `{ verbatim: true }`.
149149
- `callback` {Function}

0 commit comments

Comments
 (0)