Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database count does not exclude all databases that will be excluded #3516

Closed
garyhuntddn opened this issue May 6, 2024 · 1 comment
Closed
Assignees

Comments

@garyhuntddn
Copy link
Contributor

garyhuntddn commented May 6, 2024

Version of the script
dev branch

What is the current behavior?
The numebr of databases reported excludes those identified for exclusion, but does not exclude those which are classified with a secondary_role_allow_connections_desc = "NO" setting.

See #3511 for a possible fix

If the current behavior is a bug, please provide the steps to reproduce.
Query a server with a large number of databases, of which some will have secondary_role_allow_connections_desc = NO

What is the expected behavior?
That the number of databases reported is consistent and excludes all that will not be processed

Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
will affect all versions, I'm on v2022 on Win and *nix

@BrentOzar
Copy link
Member

Thanks for the pull request! Looks good, merging into the dev branch, will be in the next release with credit to you in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants