Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp_AllNightLog_Setup fails silently if @BackupPath not set #2474

Closed
BurtCrowne opened this issue Jul 13, 2020 · 3 comments · Fixed by #2475
Closed

sp_AllNightLog_Setup fails silently if @BackupPath not set #2474

BurtCrowne opened this issue Jul 13, 2020 · 3 comments · Fixed by #2475

Comments

@BurtCrowne
Copy link
Contributor

Version of the script
@Version = '3.96', @VersionDate = '20200712'

What is the current behavior?
Output of @help=1 has this snippet in it:
"@BackupPath NVARCHAR(MAX), defaults to = ''D:\Backup''. You 99.99999% will need to change this path to something else. This tells Ola''s job where to put backups."
The code actually just sets and leaves it at NULL if not specified.
msdbCentral created with no tables, but 22 jobs are created as expected
Message in output is "@tbl_sql is NULL for some reason".. not helpful to the user
If the current behavior is a bug, please provide the steps to reproduce.
Reproduce by omitting @BackupPath value when invoking SP
What is the expected behavior?
Check if @BackupPath is NULL, issue Raiserror and exit
Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
No idea if this ever worked correctly

@BurtCrowne
Copy link
Contributor Author

I'll submit a fix shortly

@BrentOzar
Copy link
Member

OK, great, thanks!

@BrentOzar BrentOzar linked a pull request Jul 14, 2020 that will close this issue
@BrentOzar
Copy link
Member

Merged into dev, and it'll be in the August release along with credit to you in the release notes. Thanks!

@BrentOzar BrentOzar added this to the 2020-08 Release milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants